feat: enhances S3Download to filter by traced table names #1374
+44
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staheri14
requested review from
rootulp and
ninabarbakadze
and removed request for
a team
rootulp
previously approved these changes
Jun 4, 2024
evan-forbes
previously approved these changes
Jun 5, 2024
cristaloleg
reviewed
Jun 5, 2024
rootulp
previously approved these changes
Jun 5, 2024
staheri14
dismissed stale reviews from rootulp, rach-id, and evan-forbes
via
51ad646
|
The govulncheck error will be resolved by #1377 |
rootulp
approved these changes
Jun 5, 2024
evan-forbes
approved these changes
Jun 6, 2024
cristaloleg
approved these changes
Jun 6, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jun 6, 2024
This PR updates the `S3Download` implementation to allow specifying the names of the traced tables when downloading from an S3 bucket. This enhancement enables file filtering and reduces the amount of data downloaded. It is a desirable feature when interacting with the traced data of large network tests. If no table name is provided, then `S3Download` downloads all the traced tables. (cherry picked from commit 800924f)
staheri14
added a commit
that referenced
this pull request
Jul 25, 2024
)" This reverts commit 800924f.
staheri14
added a commit
that referenced
this pull request
Jul 29, 2024
cmwaters
pushed a commit
that referenced
this pull request
Aug 13, 2024
This PR updates the `S3Download` implementation to allow specifying the names of the traced tables when downloading from an S3 bucket. This enhancement enables file filtering and reduces the amount of data downloaded. It is a desirable feature when interacting with the traced data of large network tests. If no table name is provided, then `S3Download` downloads all the traced tables.
cmwaters
added a commit
that referenced
this pull request
Aug 16, 2024
Reintroduces #1374 in a non-breaking way. This would be helpful for my compact blocks test. I don't know why it got reverted --------- Co-authored-by: Sanaz Taheri <[email protected]>
rach-id
pushed a commit
that referenced
this pull request
Nov 18, 2024
Reintroduces #1374 in a non-breaking way. This would be helpful for my compact blocks test. I don't know why it got reverted --------- Co-authored-by: Sanaz Taheri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
S3Downloadimplementation to allow specifying the names of the traced tables when downloading from an S3 bucket. This enhancement enables file filtering and reduces the amount of data downloaded. It is a desirable feature when interacting with the traced data of large network tests. If no table name is provided, thenS3Downloaddownloads all the traced tables.