Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate and fix e2e flakey tests #1231

Closed
ninabarbakadze opened this issue Feb 15, 2024 · 0 comments · Fixed by #1609
Closed

Investigate and fix e2e flakey tests #1231

ninabarbakadze opened this issue Feb 15, 2024 · 0 comments · Fixed by #1609

Comments

@ninabarbakadze
Copy link
Member

Description

Currently, there are multiples test in the e2e test suit that are flakey due to some of the recent changes introduced in core. Investigate and fix flakey tests.

@evan-forbes evan-forbes linked a pull request Feb 12, 2025 that will close this issue
evan-forbes added a commit that referenced this issue Feb 12, 2025
Closes #1611

## Description

This PR forces no tracing, removes experiment disconnections, and
removes unused abilities in the e2e tests such as pyroscope.

Tracing isn't super useful for small networks, and pyroscope is only
useful in we're looking at a node in real network with sustained load.

Removing these things allow the e2e pass on my local machine (existing
v0.34.x-celestia does not) therefore I think it makes sense that also
makes the e2e less flakey.

This PR does not fix the refused connections that started popping up a
month or two ago, I'm not 100% of the cause of that, but it doesn't
occur in cometBFT. I tried using other docker images, but since we're
using comet-db v0.7, we're stuck with needing bullseye, which uses old
versions of rocksdb.

closes: #1611 #1537 #1231 #1230
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant