Skip to content

Commit d2ca0a2

Browse files
authoredFeb 12, 2025··
fix: use v0.38's e2e test (#1609)
Closes #1611 ## Description This PR forces no tracing, removes experiment disconnections, and removes unused abilities in the e2e tests such as pyroscope. Tracing isn't super useful for small networks, and pyroscope is only useful in we're looking at a node in real network with sustained load. Removing these things allow the e2e pass on my local machine (existing v0.34.x-celestia does not) therefore I think it makes sense that also makes the e2e less flakey. This PR does not fix the refused connections that started popping up a month or two ago, I'm not 100% of the cause of that, but it doesn't occur in cometBFT. I tried using other docker images, but since we're using comet-db v0.7, we're stuck with needing bullseye, which uses old versions of rocksdb. closes: #1611 #1537 #1231 #1230
1 parent 7301d39 commit d2ca0a2

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

68 files changed

+2049
-8869
lines changed
 

‎DOCKER/Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Use a build arg to ensure that both stages use the same,
22
# hopefully current, go version.
3-
ARG GOLANG_BASE_IMAGE=golang:1.23.5-alpine
3+
ARG GOLANG_BASE_IMAGE=golang:1.23.6-alpine
44

55
# stage 1 Generate CometBFT Binary
66
FROM --platform=$BUILDPLATFORM $GOLANG_BASE_IMAGE as builder

‎README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ This repo intends on preserving the minimal possible diff with [cometbft/cometbf
4949
- **specific to Celestia**: consider if [celestia-app](https://github.com/celestiaorg/celestia-app) is a better target
5050
- **not specific to Celestia**: consider making the contribution upstream in CometBFT
5151

52-
1. [Install Go](https://go.dev/doc/install) 1.23.5+
52+
1. [Install Go](https://go.dev/doc/install) 1.23.6+
5353
2. Fork this repo
5454
3. Clone your fork
5555
4. Find an issue to work on (see [good first issues](https://github.com/celestiaorg/celestia-core/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22))

0 commit comments

Comments
 (0)
Please sign in to comment.