Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flags): Fix Payload Builder Flags #2442

Merged
merged 1 commit into from
Jan 30, 2025
+14 −4
Merged

fix(flags): Fix Payload Builder Flags #2442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions cli/flags/flags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ const (
BeaconKitAcceptTos = beaconKitRoot + "accept-tos"

// Builder Config.
builderRoot = beaconKitRoot + "payload-builder."
SuggestedFeeRecipient = builderRoot + "suggested-fee-recipient"
LocalBuilderEnabled = builderRoot + "local-builder-enabled"
LocalBuildPayloadTimeout = builderRoot + "local-build-payload-timeout"
builderRoot = beaconKitRoot + "payload-builder."
SuggestedFeeRecipient = builderRoot + "suggested-fee-recipient"
BuilderEnabled = builderRoot + "enabled"
BuildPayloadTimeout = builderRoot + "payload-timeout"
Comment on lines +36 to +37
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These flags were not used before. Hence the incorrect local-builder- went unnoticed.

Copy link
Collaborator

@abi87 abi87 Jan 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Are they used now? Should we drop them?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to drop them - i will use them for testing


// Validator Config.
validatorRoot = beaconKitRoot + "validator."
Expand Down Expand Up @@ -101,6 +101,16 @@ func AddBeaconKitFlags(startCmd *cobra.Command) {
defaultCfg.Engine.RPCJWTRefreshInterval,
"rpc jwt refresh interval",
)
startCmd.Flags().Bool(
BuilderEnabled,
defaultCfg.PayloadBuilder.Enabled,
"payload builder enabled",
)
startCmd.Flags().Duration(
BuildPayloadTimeout,
defaultCfg.PayloadBuilder.PayloadTimeout,
"payload builder timeout",
)
startCmd.Flags().String(
SuggestedFeeRecipient,
defaultCfg.PayloadBuilder.SuggestedFeeRecipient.Hex(),
Expand Down
Loading