fix(flags): Fix Payload Builder Flags #2442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2442 +/- ##
==========================================
- Coverage 31.59% 31.57% -0.03%
==========================================
Files 348 348
Lines 15519 15529 +10
Branches 20 20
==========================================
Hits 4903 4903
- Misses 10272 10282 +10
Partials 344 344
|
rezbera
commented
Jan 30, 2025
Comment on lines
+36
to
+37
| BuilderEnabled = builderRoot + "enabled" | ||
| BuildPayloadTimeout = builderRoot + "payload-timeout" |
There was a problem hiding this comment.
These flags were not used before. Hence the incorrect local-builder- went unnoticed.
There was a problem hiding this comment.
Nice catch! Are they used now? Should we drop them?
There was a problem hiding this comment.
no need to drop them - i will use them for testing
abi87
approved these changes
Jan 30, 2025
shotes
pushed a commit
that referenced
this pull request
Feb 3, 2025
shotes
pushed a commit
that referenced
this pull request
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix was required for the testing work as the flags are not used and do not have the correct mapstructure. This brings it in line with the yaml file format.