Fix node cross compile on Windows #916

gregmagolan · 2019-07-16T05:34:41Z

Fixes #909

Globegitter · 2019-07-16T05:47:57Z

examples/nestjs/src/BUILD.bazel

+        ":app",
+    ],
+    entry_point = ":main.ts",
+    node_modules = "@npm//:node_modules",


To be honest we should update rules_docker to not require this anymore so we just use fine-grained deps. Otherwise the image can really blow up in size. I will get a PR ready shortly for that. My workaround (and also from other users I have read) is to point this to an empty filegroup and just use fine-grained deps.

See: bazelbuild/rules_docker#1000

Globegitter · 2019-07-16T05:48:37Z

internal/node/node_repositories.bzl

@@ -197,7 +197,7 @@ def _prepare_node(repository_ctx):
    """

    # TODO: Maybe we want to encode the OS as a specific attribute rather than do it based on naming?
-    is_windows = is_windows_os(repository_ctx) or "_windows_" in repository_ctx.attr.name
+    is_windows = "_windows_" in repository_ctx.attr.name


Yeah so it was the issue we talked about, thanks @gregmagolan for the quick fix.

No prob. The trouble is getting coverage on Windows. buildkite fails on Windows when adding rules_docker because of some python issue 🙄

I don't think there is much documentation on it, but I think for windows you might have to explicitely pass in the autodetecting_toolchain_nonstrict - I could not find any documentation on it but just the comment here: https://github.com/bazelbuild/bazel/blob/00ec2e76e36ea540d8c26c5b9608cd38414b7d70/tools/python/pywrapper_template.txt#L87

Other than that rules_docker is just migrating everything away from python to go, but I think finishing that up is still a few weeks away.

Actually finding there still is: bazelbuild/bazel#7844

Seems the python toolchain for windows is still in a poor state and we would need to define a python toolchain manually as is done here: irengrig/bazel@10840c4#diff-c467ef71bdf4e156e40ab02be09dccd5R368

Ahhh. Thanks for looking that up. #909 is reproducible without docker so simplified this PR to avoid the docker rules for now.

Fixes issue bazel-contrib#909: Toolchains support: Failed to build on Windows for Linux

gregmagolan · 2019-07-16T06:18:46Z

buildkite failure observed without fix commit same as #909`:


(06:15:05) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
--
  | (06:15:05) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/npm_package/BUILD.bazel:15:1: //internal/npm_package:packager_bin: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:05) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:05) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/e2e/node/BUILD.bazel:5:1: //internal/e2e/node:test: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:05) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:05) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/rollup/BUILD.bazel:95:1: //internal/rollup:test: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:05) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:05) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/rollup/BUILD.bazel:72:1: //internal/rollup:tsc-directory_bin: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:05) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:05) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/npm_install/test/BUILD.bazel:22:1: //internal/npm_install/test:test.accept: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:05) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:05) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/web_package/BUILD.bazel:21:1: //internal/web_package:assembler: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:05) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:05) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/e2e/node/BUILD.bazel:26:1: //internal/e2e/node:fail_test: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:05) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:05) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/npm_install/test/BUILD.bazel:9:1: //internal/npm_install/test:test: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:05) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:05) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/rollup/BUILD.bazel:55:1: //internal/rollup:terser: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:05) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:05) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/rollup/BUILD.bazel:63:1: //internal/rollup:terser-wrapped_bin: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:05) INFO: From Generated UMD bundle for core-util-is npm package [browserify]:
  | (node:6228) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
  | (06:15:05) INFO: From Generated UMD bundle for minimist npm package [browserify]:
  | (node:6956) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
  | (06:15:05) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:05) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/npm_install/BUILD.bazel:30:1: //internal/npm_install:browserify-wrapped: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:05) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:05) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/web_package/BUILD.bazel:29:1: //internal/web_package:injector: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:05) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:05) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:05) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/node/test/BUILD.bazel:65:1: //internal/node/test:module_name_test_bin: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:05) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:05) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/web_package/BUILD.bazel:21:1: //internal/web_package:assembler_bin: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:05) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/node/test/BUILD.bazel:17:1: //internal/node/test:has_deps_legacy_bin: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:05) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/web_package/BUILD.bazel:55:1: //internal/web_package:assembler_test: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/packages/create/BUILD.bazel:23:1: //packages/create:test: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/jasmine_node_test/test/BUILD.bazel:15:1: //internal/jasmine_node_test/test:dot_spec_test: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/rollup/BUILD.bazel:72:1: //internal/rollup:tsc-directory: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/npm_install/BUILD.bazel:30:1: //internal/npm_install:browserify-wrapped_bin: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/jasmine_node_test/test/BUILD.bazel:9:1: //internal/jasmine_node_test/test:underscore_test_test: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/rollup/BUILD.bazel:47:1: //internal/rollup:tsc_bin: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/rollup/BUILD.bazel:36:1: //internal/rollup:rollup: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/e2e/fine_grained_no_bin/BUILD.bazel:8:1: //internal/e2e/fine_grained_no_bin:index_bin: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/jasmine_node_test/test/BUILD.bazel:3:1: //internal/jasmine_node_test/test:underscore_spec_test: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/rollup/BUILD.bazel:81:1: //internal/rollup:source-map-explorer_bin: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) INFO: From Generated UMD bundle for sinon npm package [browserify]:
  | (node:6596) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
  | (06:15:06) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/rollup/BUILD.bazel:63:1: //internal/rollup:terser-wrapped: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/npm_install/test/BUILD.bazel:22:1: //internal/npm_install/test:test.accept_bin: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/jasmine_node_test/test/BUILD.bazel:21:1: //internal/jasmine_node_test/test:dot_test_test: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/node/test/BUILD.bazel:37:1: //internal/node/test:has_deps_hybrid_bin: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/npm_install/test/BUILD.bazel:57:1: //internal/npm_install/test:browserify_test: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/rollup/BUILD.bazel:81:1: //internal/rollup:source-map-explorer: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/jasmine_node_test/test/BUILD.bazel:27:1: //internal/jasmine_node_test/test:no_jasmine_test: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/npm_package/BUILD.bazel:15:1: //internal/npm_package:packager: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/node/test/BUILD.bazel:9:1: //internal/node/test:no_deps: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/rollup/BUILD.bazel:47:1: //internal/rollup:tsc: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/web_package/BUILD.bazel:29:1: //internal/web_package:injector_bin: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/e2e/fine_grained_no_bin/BUILD.bazel:8:1: //internal/e2e/fine_grained_no_bin:index: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/e2e/node/BUILD.bazel:34:1: //internal/e2e/node:lib_test: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/rollup/BUILD.bazel:55:1: //internal/rollup:terser_bin: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/web_package/BUILD.bazel:45:1: //internal/web_package:injector_test: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/e2e/fine_grained_deps/BUILD.bazel:6:2: //internal/e2e/fine_grained_deps:test_yarn: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/node/test/BUILD.bazel:52:1: //internal/node/test:has_entry_file: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/node/test/BUILD.bazel:17:1: //internal/node/test:has_deps_legacy: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/node/test/BUILD.bazel:9:1: //internal/node/test:no_deps_bin: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/node/test/BUILD.bazel:52:1: //internal/node/test:has_entry_file_bin: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/node/test/BUILD.bazel:65:1: //internal/node/test:module_name_test: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/node/test/BUILD.bazel:26:1: //internal/node/test:has_deps_bin: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/node/test/BUILD.bazel:26:1: //internal/node/test:has_deps: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/e2e/fine_grained_deps/BUILD.bazel:6:2: //internal/e2e/fine_grained_deps:test_npm: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/rollup/BUILD.bazel:36:1: //internal/rollup:rollup_bin: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/e2e/fine_grained_deps/BUILD.bazel:21:2: //internal/e2e/fine_grained_deps:fine_grained_test_yarn: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/e2e/fine_grained_deps/BUILD.bazel:21:2: //internal/e2e/fine_grained_deps:fine_grained_test_npm: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/npm_package/test/BUILD.bazel:40:1: //internal/npm_package/test:test: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:06) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/node/test/BUILD.bazel:37:1: //internal/node/test:has_deps_hybrid: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:08) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:08) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/e2e/rollup/BUILD.bazel:16:1: //internal/e2e/rollup:test: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:08) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:08) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/e2e/rollup_code_splitting/BUILD.bazel:52:1: //internal/e2e/rollup_code_splitting:test-outputgroups: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:08) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:08) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/e2e/rollup_code_splitting/BUILD.bazel:14:1: //internal/e2e/rollup_code_splitting:test: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:08) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:08) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/web_package/test/BUILD.bazel:21:1: //internal/web_package/test:test: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:08) INFO: From Optimizing JavaScript internal/e2e/rollup/bundle.min.umd.js [terser]:
  | INFO: Using input source map: bazel-out/x64_windows-fastbuild/bin/internal/e2e/rollup/bundle.umd.js.map
  | (06:15:08) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:08) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/e2e/rollup/BUILD.bazel:86:1: //internal/e2e/rollup:test-outputgroups: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:08) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:08) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/e2e/rollup_fine_grained_deps/BUILD.bazel:68:1: //internal/e2e/rollup_fine_grained_deps:test: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:08) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:08) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/e2e/rollup_fine_grained_deps/BUILD.bazel:81:1: //internal/e2e/rollup_fine_grained_deps:test.accept_bin: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:08) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:08) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/e2e/rollup_fine_grained_deps/BUILD.bazel:81:1: //internal/e2e/rollup_fine_grained_deps:test.accept: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:08) ERROR: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:08) ERROR: D:/b/bk-windows-java8-jdgn/bazel/rules-nodejs-nodejs/internal/web_package/test2/BUILD.bazel:34:1: //internal/web_package/test2:test: missing input file '@nodejs_linux_amd64//:bin/nodejs/node.exe'
  | (06:15:08) INFO: Elapsed time: 21.649s, Critical Path: 3.05s
  | (06:15:08) INFO: 60 processes: 44 remote cache hit, 16 local.
  | (06:15:08) FAILED: Build did NOT complete successfully

alexeagle

love the test harness fixes

gregmagolan requested review from alexeagle and kyliau as code owners July 16, 2019 05:34

googlebot added the cla: yes label Jul 16, 2019

gregmagolan force-pushed the fix-909 branch from 6cb7324 to 0e646a3 Compare July 16, 2019 05:45

Globegitter reviewed Jul 16, 2019

View reviewed changes

gregmagolan added 2 commits July 16, 2019 02:17

test: test node_repositories cross compile in buildkite

49b377c

fix: fix for node windows cross-compile

67b2520

Fixes issue bazel-contrib#909: Toolchains support: Failed to build on Windows for Linux

gregmagolan force-pushed the fix-909 branch from 09d5f98 to 67b2520 Compare July 16, 2019 06:17

alexeagle approved these changes Jul 16, 2019

View reviewed changes

alexeagle merged commit 001d945 into bazel-contrib:master Jul 16, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix node cross compile on Windows #916

Fix node cross compile on Windows #916

gregmagolan commented Jul 16, 2019 •

edited

Loading

Globegitter Jul 16, 2019

gregmagolan Jul 16, 2019

Globegitter Jul 16, 2019

Globegitter Jul 16, 2019

gregmagolan Jul 16, 2019

Globegitter Jul 16, 2019

Globegitter Jul 16, 2019

Globegitter Jul 16, 2019

gregmagolan Jul 16, 2019

gregmagolan commented Jul 16, 2019

alexeagle left a comment

Fix node cross compile on Windows #916

Fix node cross compile on Windows #916

Conversation

gregmagolan commented Jul 16, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gregmagolan commented Jul 16, 2019

alexeagle left a comment

Choose a reason for hiding this comment

gregmagolan commented Jul 16, 2019 •

edited

Loading