Skip to content

Commit 0e646a3

Browse files
committed
test: test node_repositories cross compile with rules_docker nodejs_image
1 parent 38c810f commit 0e646a3

File tree

5 files changed

+56
-1
lines changed

5 files changed

+56
-1
lines changed

.bazelci/presubmit.yml

+25-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
---
2-
platforms:
2+
tasks:
33
ubuntu1604:
4+
name: ubuntu1604
5+
platform: ubuntu1604
46
run_targets:
57
- "@nodejs//:yarn"
68
- "//internal/node/test:no_deps"
@@ -18,6 +20,8 @@ platforms:
1820
test_targets:
1921
- "//..."
2022
ubuntu1804:
23+
name: ubuntu1804
24+
platform: ubuntu1804
2125
run_targets:
2226
- "@nodejs//:yarn"
2327
- "//internal/node/test:no_deps"
@@ -38,6 +42,8 @@ platforms:
3842
test_targets:
3943
- "//..."
4044
macos:
45+
name: macos
46+
platform: macos
4147
run_targets:
4248
- "@nodejs//:yarn"
4349
- "//internal/node/test:no_deps"
@@ -54,7 +60,16 @@ platforms:
5460
- "//..."
5561
test_targets:
5662
- "//..."
63+
macos_cross_compile:
64+
name: macos_cross_compile
65+
platform: macos
66+
build_flags:
67+
- "--platforms=@build_bazel_rules_nodejs//toolchains/node:linux_amd64"
68+
build_targets:
69+
- "//internal/e2e/nodejs_image:docker"
5770
windows:
71+
name: windows
72+
platform: windows
5873
run_targets:
5974
- "@nodejs//:yarn"
6075
- "//internal/node/test:no_deps"
@@ -73,6 +88,15 @@ platforms:
7388
- "--test_tag_filters=-fix-windows"
7489
test_targets:
7590
- "//..."
91+
windows_cross_compile:
92+
name: windows_cross_compile
93+
platform: windows
94+
build_flags:
95+
- "--platforms=@build_bazel_rules_nodejs//toolchains/node:linux_amd64"
96+
build_targets:
97+
- "//internal/e2e/nodejs_image:docker"
7698
rbe_ubuntu1604:
99+
name: rbe_ubuntu1604
100+
platform: rbe_ubuntu1604
77101
build_targets:
78102
- "//..."

WORKSPACE

+14
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,20 @@ load("@internal_e2e_packages//:setup_workspace.bzl", "internal_e2e_packages_setu
9292

9393
internal_e2e_packages_setup_workspace()
9494

95+
load(
96+
"@io_bazel_rules_docker//repositories:repositories.bzl",
97+
container_repositories = "repositories",
98+
)
99+
100+
container_repositories()
101+
102+
load(
103+
"@io_bazel_rules_docker//nodejs:image.bzl",
104+
nodejs_image_repositories = "repositories",
105+
)
106+
107+
nodejs_image_repositories()
108+
95109
# Dependencies to run skydoc
96110
load("@io_bazel_rules_sass//sass:sass_repositories.bzl", "sass_repositories")
97111

internal/e2e/nodejs_image/BUILD.bazel

+8
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
load("@io_bazel_rules_docker//nodejs:image.bzl", "nodejs_image")
2+
3+
# bazel build --platforms=@build_bazel_rules_nodejs//toolchains/node:linux_amd64 //internal/e2e/nodejs_image:docker
4+
nodejs_image(
5+
name = "docker",
6+
entry_point = ":main.js",
7+
node_modules = "@npm//:node_modules",
8+
)

internal/e2e/nodejs_image/main.js

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
console.log('hello world')

package.bzl

+8
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,14 @@ def rules_nodejs_dev_dependencies():
4242
strip_prefix = "rules_sass-86ca977cf2a8ed481859f83a286e164d07335116",
4343
)
4444

45+
# For test coverage
46+
http_archive(
47+
name = "io_bazel_rules_docker",
48+
sha256 = "87fc6a2b128147a0a3039a2fd0b53cc1f2ed5adb8716f50756544a572999ae9a",
49+
strip_prefix = "rules_docker-0.8.1",
50+
urls = ["https://github.com/bazelbuild/rules_docker/archive/v0.8.1.tar.gz"],
51+
)
52+
4553
# Needed for stardoc
4654
http_archive(
4755
name = "io_bazel",

0 commit comments

Comments
 (0)