Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove allow_attributes false positive exceptions once Rust is updated #1580

Closed
ethanoroshiba opened this issue Sep 27, 2024 · 1 comment · Fixed by #1857
Closed

remove allow_attributes false positive exceptions once Rust is updated #1580

ethanoroshiba opened this issue Sep 27, 2024 · 1 comment · Fixed by #1857
Assignees
@ethanoroshiba
Labels
code-quality core pertaining to the astria-core crate ignore-stale Override for issues or PRs which should not be removed if stale.

Comments

@ethanoroshiba
Copy link
Contributor

ethanoroshiba commented Sep 27, 2024 •
edited
Loading

After updating to Rust 1.81, I came across a bizarre false positive for clippy::allow_attributes and clippy:allow_attributes_without_reason:
rust-lang/rust-clippy#13380
rust-lang/rust-clippy#13463

It appears this has been fixed and will be pushed out as of Rust 1.83. We should remove this exception when we upgrade:

astria/crates/astria-core/src/protocol/genesis/v1alpha1.rs

Lines 134 to 139 in e267d1c

#[expect(
clippy::allow_attributes,
clippy::allow_attributes_without_reason,
reason = "false positive"
)]
fn try_from_raw_ref(raw: &Self::Raw) -> Result<Self, Self::Error> {

┆Issue Number: ENG-872
@ethanoroshiba ethanoroshiba added code-quality core pertaining to the astria-core crate labels Sep 27, 2024
@ethanoroshiba ethanoroshiba mentioned this issue Sep 27, 2024
Merged
@ethanoroshiba ethanoroshiba mentioned this issue Dec 6, 2024
Merged
@joroshiba
Copy link
Member

This issue is stale because it has been open 45 days with no activity. Remove stale label or this issue
be closed in 7 days.

@ethanoroshiba ethanoroshiba added ignore-stale Override for issues or PRs which should not be removed if stale. and removed stale labels Dec 16, 2024
@ethanoroshiba ethanoroshiba self-assigned this Jan 7, 2025
github-merge-queue bot pushed a commit that referenced this issue Jan 16, 2025
@ethanoroshiba
chore: bump to rust version 1.83 (#1857)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
2899049 
## Summary
Bumped MSRV to 1.83 and made small changes to appease new Clippy lints.

## Background
Rust 1.83 solves some bizarre Clippy false positives, improved lints
also revealed some nit improvement points. Bumping MSRV also doesn't
have a huge cost, since we don't have many downstream users.

## Changes
- Bumped MSRV.
- Changed small bits to appease Clippy, mostly changing to use lifetime
elisions.
- rustfmt made a bunch of changes with the new version

## Testing
Passing all tests.

## Changelogs
Changelogs updated for crates which have already been released.

## Related Issues
closes #1580
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ethanoroshiba ethanoroshiba

Labels
code-quality core pertaining to the astria-core crate ignore-stale Override for issues or PRs which should not be removed if stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: bump to rust version 1.83 astriaorg/astria
2 participants
@joroshiba @ethanoroshiba