Skip to content

ci: Add swift wasm builds to CI to prevent future breakages to wasm builds #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,9 @@ jobs:
uses: apple/swift-nio/.github/workflows/macos_tests.yml@main
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, the new CI tests in this PR won't pass until #174 is merged (to add wasm compilation support to swift-distributed-tracing).

with:
build_scheme: swift-distributed-tracing-Package

wasm-sdk:
name: WebAssembly SDK
# TODO: Switch to this line after https://github.com/apple/swift-nio/pull/3159/ is merged
# uses: apple/swift-nio/.github/workflows/wasm_sdk.yml@main
uses: kateinoigakukun/swift-nio/.github/workflows/wasm_sdk.yml@katei/add-wasm-ci
Comment on lines +36 to +38
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging, this will need changed as follows. Leaving as is until dependencies and testing are in order.

Suggested change
# TODO: Switch to this line after https://github.com/apple/swift-nio/pull/3159/ is merged
# uses: apple/swift-nio/.github/workflows/wasm_sdk.yml@main
uses: kateinoigakukun/swift-nio/.github/workflows/wasm_sdk.yml@katei/add-wasm-ci
uses: apple/swift-nio/.github/workflows/wasm_sdk.yml@main

6 changes: 6 additions & 0 deletions .github/workflows/pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,12 @@ jobs:
linux_6_1_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable"
linux_nightly_6_0_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable"
linux_nightly_main_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable"

wasm-sdk:
name: WebAssembly SDK
# TODO: Switch to this line after https://github.com/apple/swift-nio/pull/3159/ is merged
# uses: apple/swift-nio/.github/workflows/wasm_sdk.yml@main
uses: kateinoigakukun/swift-nio/.github/workflows/wasm_sdk.yml@katei/add-wasm-ci
Comment on lines +29 to +31
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging, this will need changed as follows. Leaving as is until dependencies and testing are in order.

Suggested change
# TODO: Switch to this line after https://github.com/apple/swift-nio/pull/3159/ is merged
# uses: apple/swift-nio/.github/workflows/wasm_sdk.yml@main
uses: kateinoigakukun/swift-nio/.github/workflows/wasm_sdk.yml@katei/add-wasm-ci
uses: apple/swift-nio/.github/workflows/wasm_sdk.yml@main


benchmarks:
name: Benchmarks
Expand Down