ci: Add swift wasm builds to CI to prevent future breakages to wasm builds #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 tasks
scottmarchant
commented
Jun 24, 2025
Comment on lines
+36
to
+38
| # TODO: Switch to this line after https://github.com/apple/swift-nio/pull/3159/ is merged | ||
| # uses: apple/swift-nio/.github/workflows/wasm_sdk.yml@main | ||
| uses: kateinoigakukun/swift-nio/.github/workflows/wasm_sdk.yml@katei/add-wasm-ci |
There was a problem hiding this comment.
Before merging, this will need changed as follows. Leaving as is until dependencies and testing are in order.
Suggested change
| # TODO: Switch to this line after https://github.com/apple/swift-nio/pull/3159/ is merged | |
| # uses: apple/swift-nio/.github/workflows/wasm_sdk.yml@main | |
| uses: kateinoigakukun/swift-nio/.github/workflows/wasm_sdk.yml@katei/add-wasm-ci | |
| uses: apple/swift-nio/.github/workflows/wasm_sdk.yml@main |
scottmarchant
commented
Jun 24, 2025
Comment on lines
+29
to
+31
| # TODO: Switch to this line after https://github.com/apple/swift-nio/pull/3159/ is merged | ||
| # uses: apple/swift-nio/.github/workflows/wasm_sdk.yml@main | ||
| uses: kateinoigakukun/swift-nio/.github/workflows/wasm_sdk.yml@katei/add-wasm-ci |
There was a problem hiding this comment.
Before merging, this will need changed as follows. Leaving as is until dependencies and testing are in order.
Suggested change
| # TODO: Switch to this line after https://github.com/apple/swift-nio/pull/3159/ is merged | |
| # uses: apple/swift-nio/.github/workflows/wasm_sdk.yml@main | |
| uses: kateinoigakukun/swift-nio/.github/workflows/wasm_sdk.yml@katei/add-wasm-ci | |
| uses: apple/swift-nio/.github/workflows/wasm_sdk.yml@main |
scottmarchant
commented
Jun 24, 2025
| @@ -30,3 +30,9 @@ jobs: | |||
| uses: apple/swift-nio/.github/workflows/macos_tests.yml@main | |||
There was a problem hiding this comment.
Note, the new CI tests in this PR won't pass until #174 is merged (to add wasm compilation support to swift-distributed-tracing).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary
Added swift wasm as a CI target, to help prevent future breakages to swift wasm builds in DataLoader
Details
pull_requestandmain, by adding references to new wasm build workflow from swift-nio.Notes
PR Dependencies
The following PR's must be merged before this PR can be merged:
Testing done
Verified new github workflow starts correctly. But cannot verify full functionality until the dependent PR's are merged.
See https://github.com/PassiveLogic/swift-distributed-tracing/actions/runs/15858257532/job/44708826507?pr=1
Remaining work
main.