Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix proxy support for jwks retrieval #1776

Merged
merged 1 commit into from
Jul 29, 2024
Merged

fix proxy support for jwks retrieval #1776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/attest/RELEASES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# @actions/attest Releases

### 1.3.1

- Fix bug with proxy support when retrieving JWKS for OIDC issuer

### 1.3.0

- Dynamic construction of Sigstore API URLs
Expand Down
4 changes: 2 additions & 2 deletions packages/attest/__tests__/oidc.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ describe('getIDTokenClaims', () => {
})

it('throws an error', async () => {
await expect(getIDTokenClaims(issuer)).rejects.toThrow(/issuer invalid/)
await expect(getIDTokenClaims(issuer)).rejects.toThrow(/unexpected "iss"/)
})
})

Expand All @@ -115,7 +115,7 @@ describe('getIDTokenClaims', () => {
})

it('throw an error', async () => {
await expect(getIDTokenClaims(issuer)).rejects.toThrow(/audience invalid/)
await expect(getIDTokenClaims(issuer)).rejects.toThrow(/unexpected "aud"/)
})
})

Expand Down
Loading
Loading