fix proxy support for jwks retrieval #1776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian DeHamer <[email protected]>
bdehamer
force-pushed
the
bdehamer/jwks-proxy-fix
branch
from
74d368f to
b28406b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the provenance generation logic, an OIDC token is retrieved from the GHA issuer in order to populate the claims in the attestation. The process of verifying the OIDC token requires that the JSON Web Key Set (JWKS) for the GHA OIDC issuer is retrieved. The library (
jwks-rsa) we were using to retrieve the key set was not respecting the proxy settings of the actions runner. If a user was using a self-hosted runner behind a proxy the request to retrieve the JWKS would fail.This change re-implements the JWKS look-up to use the
@actions/http-clientlibrary for the retrieval -- this library has proxy support already included.Per: actions/attest-build-provenance#156