-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename "Fixed by vulnerabilities" column #1519
Conversation
Reference: #1501 Signed-off-by: John M. Horan <[email protected]>
@pombredanne @TG1999 Do we want a similar change from |
As discussed in the #1520 issue please use "fixing vulnerabilities" and merge! |
@@ -48,7 +48,7 @@ | |||
<span | |||
class="has-tooltip-multiline has-tooltip-black has-tooltip-arrow has-tooltip-text-left" | |||
data-tooltip="This is the number of vulnerabilities fixed by the package."> | |||
<span class="affected-fixed">Fixed by</span> vulnerabilities |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to also align the CSS class names with the latest and greatest
@pombredanne I have made the change (locally only atm) in the Packages search results page from "Fixed by vulnerabilities" (or yesterday in this PR, "Fixed vulnerabilities") to "Fixing vulnerabilities", e.g., I began to make the change you requested to the span class name for the renamed "Fixing vulnerabilities" from Rather than making two new classes for the package and vuln CSS column and similar references -- with the exact same settings -- for now I am making no change until you've had a chance to consider the current usage. If you'd like me to make separate names for each and rename where needed, please let me know and I'll do that. But first.... One more related question arises from the current change. The change above is on the Packages search result page, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Merging!
Reference: #1520 Related prior issue: #1501 Updates: #1519 Signed-off-by: John M. Horan <[email protected]>
…e-org#1520 Reference: aboutcode-org#1520 Related prior issue: aboutcode-org#1501 Updates: aboutcode-org#1519 Signed-off-by: John M. Horan <[email protected]> Signed-off-by: Michael Ehab Mikhail <[email protected]>
Reference: #1501
Reference: #1520
@pombredanne @TG1999 -- ready for your review.
Note that when I ran
make test
locally, 1 test, unrelated to my update, failed:The updated column now looks like this: