-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change label from "Fixed by vulnerabilties" to "Fixes vulnerabilities" #1501
Comments
@TG1999 There's no description -- please explain the thinking behind the change you suggest. We've changed the names of these columns several times already in the past -- happy to change again if that what the group wants, but I haven't heard from others that that's what they want. |
Not sure if this is helpful, but one way to describe the relationship we're trying to name -- from the PURL's viewpoint, the PURL is "affected by" a vuln or "fixes" a vuln; and from the vuln perspective, the vuln "affects" the PURL or is "fixed by" the PURL. 🤔 |
I think that the current parallel "by" construction makes the most sense. |
I think that "Fixes vulnerabilities" would be the best solution. |
@mjherzog @pombredanne When you have the chance, please share your views on the latest suggestion -- "Fixes vulnerabilities". |
The terminology is very context dependent as explained by @johnmhoran .
|
What I see most commonly is "fixed vulnerabilities" from a package point of view, not "fixes vulnerabilities". Juts removing the "by" should be enough |
Thanks @pombredanne. I'll make the change you suggest: "Fixed by vulnerabilties" ==> "Fixed vulnerabilities". |
Reference: #1501 Signed-off-by: John M. Horan <[email protected]>
Closed and merged in the issue #1520 that tracks changes in the models, API and UI at once |
Reference: #1520 Related prior issue: #1501 Updates: #1519 Signed-off-by: John M. Horan <[email protected]>
…e-org#1520 Reference: aboutcode-org#1520 Related prior issue: aboutcode-org#1501 Updates: aboutcode-org#1519 Signed-off-by: John M. Horan <[email protected]> Signed-off-by: Michael Ehab Mikhail <[email protected]>
The text was updated successfully, but these errors were encountered: