Speed up sync #2316
Merged
Speed up sync #2316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bencher Report| Branch | 2158-speedup-sync |
| Testbed | self-hosted |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| full-blocks-erc20-transfers/full-blocks-erc20-transfers | 📈 view plot 🚷 view threshold | 1,468.60(+24.42%)Baseline: 1,180.35 | 1,576.05 (93.18%) |
| full-blocks-evm-transfers/full-blocks-evm-transfers | 📈 view plot 🚷 view threshold | 429.69(-2.61%)Baseline: 441.23 | 568.17 (75.63%) |
| full-blocks-zil-transfers/full-blocks-zil-transfers | 📈 view plot 🚷 view threshold | 4,120.20(+3.75%)Baseline: 3,971.35 | 5,378.79 (76.60%) |
| process-empty/process-empty | 📈 view plot 🚷 view threshold | 10.25(+8.81%)Baseline: 9.42 | 11.85 (86.47%) |
…istic and eventually degenerates to 1 peer.
…n for dynamic sizing.
86667
reviewed
Feb 17, 2025
shawn-zil
force-pushed
the
2158-speedup-sync
branch
from
e2c8fd1 to
66eeaa9
Compare
86667
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speeds up Phase 1, by firing 10 concurrent requests at a time, processing 10 responses, then firing the next 10, etc. The speedup in this sense is fairly linear (at least up to 10), as expected. Since Phase 2 is CPU-bound, firing concurrent requests is unnecessary.
When processing the Phase 1 responses, it also splits the chain segment into sub-segments, based on the estimated response payload size. So, if there are large blocks, it will split the segment into several sub-segments for Phase 2 processing.
This removes support for V1 compatibility. Do not merge this until the hard-fork to >= 0.6.0