-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make P1 requests concurrent #2311
Comments
shawn-zil
added a commit
that referenced
this issue
Feb 10, 2025
shawn-zil
added a commit
that referenced
this issue
Feb 10, 2025
shawn-zil
added a commit
that referenced
this issue
Feb 11, 2025
github-merge-queue bot
pushed a commit
that referenced
this issue
Feb 19, 2025
* Resolves #2310 - migrate to VecDeque. * Resolve #2313 - ensure a unique peer in the SyncPeers set. * initial sub-segmentation #2312 * initial concurrent phase-1 #2311 * feat: working primitive concurrent requests. #2311 * Resolved #2311. Speed-up 10x. * Resolve #2314. No longer returning ExternalMessage::Acknowledgement. * nit: merge checkpoint_at with started_at function. * feat: #2313 - bias peer selection to be optimistic, previously pessimistic and eventually degenerates to 1 peer. * feat: size-based dynamic sub-segments (#2312) * feat: (#2312) drop peers due to network errors. * feat: (#2298) removing V1 compatibility. * Resolve #2312 - compute dynamic sub-segments. * nit: clippy. * nit: improve logging. * fix: DoS mitigation logic, log messages. * fix: simplify block_to_proposal(). * feat: (#2312) use gas guesstimate, when sync_size_estimate is missing. * fix: change offset computation in do_missing_metadata() in preparation for dynamic sizing. * fix: (#2313) - improve peer selection for when peer_count < MAX_CONCURRENT_PEERS. * nit: use new SyncBlockHeader for syncing instead of raw BlockHeader.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Treat it as just larger segments. Scheme:
request_missing_metadata()
is called, fire off batch request for different segments.When responses are received. Scheme:
When empty/error, mark that in the response cache.
Important to ensure that each peer is used only one-at-a-time.
The text was updated successfully, but these errors were encountered: