-
Notifications
You must be signed in to change notification settings - Fork 0
Task/andrin/str 154 #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
204eceb
AddInstruments working as expected, CreateEntity test requires a mock…
ocasta181 54f25e9
have instrument add working
ocasta181 470128c
cleanup entities_test.go
ocasta181 6cb68d8
resolve rebase conflicts
ocasta181 2603537
have instrument add working
ocasta181 4302a87
cleanup entities_test.go
ocasta181 dae2910
more merge conflicts
ocasta181 01ba44c
somehow missed a rebase conflict
ocasta181 bfb21ca
adding customData
ocasta181 bb2a8c1
resolve rebase conflicts
ocasta181 b608c66
have instrument add working
ocasta181 3413f3c
cleanup entities_test.go
ocasta181 3920e97
merge conflicts
ocasta181 47ff378
have instrument add working
ocasta181 079c663
somehow missed a rebase conflict
ocasta181 edf0616
adding customData
ocasta181 7b99fc6
another merge...
ocasta181 08bd81e
make db gets more precicely named; add getDigitalData() to unit21
ocasta181 7a86f81
add user_platform table and update unit21 entity endpoint
ocasta181 cda9e18
add user_platform and contract_platform repos; rename usercontact to …
ocasta181 a0e9ed8
round out entity api with update and customData
ocasta181 d99d59e
tests running
ocasta181 e4c39a2
Merge branch 'develop' into task/andrin/str-154
12442e4
cleanup; instrument progress; entity completion
ocasta181 9e5482c
Merge branch 'task/andrin/str-154' of github.com:String-xyz/string-ap…
ocasta181 6cdeb04
cleanup debugging logs
ocasta181 eeeebec
expose constructors
ocasta181 a447329
another constructor reference
ocasta181 5e5026e
add statusCode checking
ocasta181 8bb200b
entity and instrument tests passing
ocasta181 c490427
normalized TX vs Tx across the codebase; mostly complete structure fo…
ocasta181 4f9bcb9
transaction event tests passing
ocasta181 c84f13d
instrument tests closer to fully working
ocasta181 464f2f9
adding more data for entity; testing non-persistence of data to u21
ocasta181 03904bd
unit21 can't handle empty string values
ocasta181 c9790d0
remove debugging error thrown and commented out code
ocasta181 ffb6097
remove logs and comments
ocasta181 4950730
move out repos into own struct
ocasta181 3c1982b
fix quote typo
ocasta181 e6be36e
remove todo comment from entity model
ocasta181 2e16357
resolve merge conflicts
ocasta181 3b201c9
GetId to GetById
ocasta181 638243e
ensure verification endpoint is properly routed
ocasta181 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be JSONB, since we are dealing with it as a string array at the Go level
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the change that @saito-sv and I discussed at some length. It is the 2nd change that will need to be made to all arrays.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@auroter, we can discuss further in office hours.