Task/andrin/str 154 #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….ExpectQuery it seems
…contact to match db and avoid confusion with many-to-many index tables
…i into task/andrin/str-154
…r transaction events in unit21
auroter
reviewed
Nov 1, 2022
| @@ -13,7 +22,7 @@ CREATE TABLE device ( | |||
| type TEXT DEFAULT '', -- enum: to be defined at struct level in Go | |||
| description TEXT DEFAULT '', | |||
| fingerprint TEXT DEFAULT '', | |||
| ip_addresses JSONB DEFAULT '[]'::JSONB, | |||
| ip_addresses TEXT[] DEFAULT NULL, | |||
There was a problem hiding this comment.
This should be JSONB, since we are dealing with it as a string array at the Go level
There was a problem hiding this comment.
This is the change that @saito-sv and I discussed at some length. It is the 2nd change that will need to be made to all arrays.
There was a problem hiding this comment.
@auroter, we can discuss further in office hours.
auroter
reviewed
Nov 1, 2022
auroter
reviewed
Nov 2, 2022
auroter
reviewed
Nov 2, 2022
auroter
reviewed
Nov 2, 2022
auroter
reviewed
Nov 2, 2022
auroter
reviewed
Nov 2, 2022
auroter
reviewed
Nov 2, 2022
auroter
approved these changes
Nov 2, 2022
saito-sv
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit21 Integration layer is now complete.
To test:
Run
go test ./pkg/internal/unit21/Go to https://sandbox2.unit21.com/
Confirm that a new entity, instrument, and transaction were all created at the time you ran the tests. Confirm that each are filled out to a reasonable level of completion. Only missing extraneous details we don't maintain.