polyval: Refactor in prep for soft backend rewrite #8
+82
−142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This incrementally incorporates some of the refactoring changes from #7 in order to simplify the diff for that PR (and because those changes seem generally good regardless).
newpavlov
approved these changes
Sep 3, 2019
| clmul::PseudoOp::PCLMULHQLQDQ => _mm_clmulepi64_si128(a, b, 0x01), | ||
| clmul::PseudoOp::PCLMULLQHQDQ => _mm_clmulepi64_si128(a, b, 0x10), | ||
| clmul::PseudoOp::PCLMULHQHQDQ => _mm_clmulepi64_si128(a, b, 0x11), | ||
| unsafe fn pclmulqdq(a: __m128i, b: __m128i, imm: u8) -> __m128i { |
There was a problem hiding this comment.
Do we need this separate function? IIUC you can inline this code directly to Backend impl. Also target_feature attribute looks redundant, since you already check that this module is built with those features enabled. To be safe you could add a compilation error at the top of this module. Or is it a preparation for future CPUID detection?
There was a problem hiding this comment.
I can definitely look into doing a lot of additional cleanups after #7 lands, including CPUID detection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This incrementally incorporates some of the refactoring changes from #7 in order to simplify the diff for that PR (and because those changes seem generally good regardless).