polyval: Constant-time software implementation #7
+183
−172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
polyval/constant-time-soft-backend
branch
2 times, most recently
from
3bdf094 to
4d5a431
Compare
tarcieri
added a commit
that referenced
this pull request
Sep 3, 2019
This incrementally incorporates some of the refactoring changes from #7 in order to simplify the diff for that PR (and because those changes seem generally good regardless).
tarcieri
force-pushed
the
polyval/constant-time-soft-backend
branch
2 times, most recently
from
fe4e762 to
a5b36f7
Compare
tarcieri
changed the title
tarcieri
commented
Sep 3, 2019
newpavlov
reviewed
Sep 3, 2019
|
Getting some reasonable performance out of this for a software implementation: |
tarcieri
force-pushed
the
polyval/constant-time-soft-backend
branch
3 times, most recently
from
202ecd0 to
dd31c68
Compare
|
@newpavlov went ahead and pushed the cleanups you requested on #8. The resulting simplification seems to have improved the performance of that backend as well: |
tarcieri
force-pushed
the
polyval/constant-time-soft-backend
branch
5 times, most recently
from
fdd3ed5 to
4e41879
Compare
Adapts BearSSL's `ghash_ctmul64.c` into a constant-time software backend for POLYVAL.
tarcieri
force-pushed
the
polyval/constant-time-soft-backend
branch
from
4e41879 to
452a2ff
Compare
Merged
tarcieri
added a commit
that referenced
this pull request
Dec 5, 2019
Previously (in #7) BearSSL's `ghash_ctmul64.c` was adapted into a portable software backend. This commit additionally adapts BearSSL's `ghash_ctmul32.c` into a portable constant-time field arithmetic backend for POLYVAL designed for 32-bit architectures.
tarcieri
added a commit
that referenced
this pull request
Dec 5, 2019
Previously (in #7) BearSSL's `ghash_ctmul64.c` was adapted into a portable software backend. This commit additionally adapts BearSSL's `ghash_ctmul32.c` into a portable constant-time field arithmetic backend for POLYVAL designed for 32-bit architectures.
tarcieri
added a commit
that referenced
this pull request
Dec 5, 2019
Previously (in #7) BearSSL's `ghash_ctmul64.c` was adapted into a portable software backend. This commit additionally adapts BearSSL's `ghash_ctmul32.c` into a portable constant-time field arithmetic backend for POLYVAL designed for 32-bit architectures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapts BearSSL's
ghash_ctmul64.cinto a constant-time software backend for POLYVAL.References: