Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tiltrotor oscillations #386

Merged
merged 1 commit into from
Jan 4, 2020
Merged

Fix tiltrotor oscillations #386

merged 1 commit into from
Jan 4, 2020

Conversation

Jaeyoung-Lim
Copy link
Member

@Jaeyoung-Lim Jaeyoung-Lim commented Jan 3, 2020

Tilt rotors were oscillating rapidly when stationary. This was due to the high gains of the joint control pid loop of the tilt joints. This PR lowers the gains slightly so the oscillations are not visible anymore

Before PR:
tiltrotor

After PR:
tiltrotor_pr
(this is not a image, but a moving gif)
After the joint control gain has been lowered, the vehicle is still able to fly a successful mission: log

@Jaeyoung-Lim Jaeyoung-Lim requested a review from sfuhrer January 3, 2020 19:13
@dagar
Copy link
Member

dagar commented Jan 4, 2020

Thanks for finally fixing this!

@dagar dagar merged commit b35b439 into master Jan 4, 2020
@dagar dagar deleted the pr-fix-tiltrotor-up branch January 4, 2020 16:03
@dagar
Copy link
Member

dagar commented Jan 4, 2020

Updating the sitl_gazebo submodule in PX4/Firmware is blocked at the moment. PX4/PX4-Autopilot#13784

@Jaeyoung-Lim
Copy link
Member Author

@dagar Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants