Skip to content
This repository was archived by the owner on Nov 17, 2021. It is now read-only.

Quaternion maintenance: remove deprecated functions #139

Merged
merged 4 commits into from
Jul 20, 2020

Conversation

MaEtUgR
Copy link
Member

@MaEtUgR MaEtUgR commented Jul 20, 2020

While looking into implementing a new heading calculation for PX4/PX4-Autopilot#13535 I found some points in the quaternion implementation that I stumble over and over again. So it's time to fix them.

  • The conversion functions marked with XXX DEPRECATED are there since I first saw the matrix library and are duplicate to the conversion constructors.
  • I adjusted the existing conversion tests to use the constructors instead. While doing so I found some confusing reuse of qI which was set to the identity quaternion but then changed later on so I refactored the tests.
  • The half angle computed for the axis angle conversion was computed using a float once instead of the template type.

@MaEtUgR MaEtUgR self-assigned this Jul 20, 2020
@MaEtUgR MaEtUgR changed the title Quaternion maintenance Quaternion maintenance: remove deprecated functions Jul 20, 2020
@coveralls
Copy link

coveralls commented Jul 20, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling ae8b888 on quaternion-maintenance into 7a3009f on master.

@MaEtUgR MaEtUgR merged commit a126be0 into master Jul 20, 2020
@MaEtUgR MaEtUgR deleted the quaternion-maintenance branch July 20, 2020 16:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants