Skip to content
This repository was archived by the owner on Aug 1, 2024. It is now read-only.

Improve planning repeatability #555

Merged
merged 1 commit into from
Feb 7, 2020
Merged

Improve planning repeatability #555

merged 1 commit into from
Feb 7, 2020

Conversation

jkflying
Copy link
Contributor

Use the longest A* path weighted by cost, since we don't plan all of the way to the goal.

Before, the path chosen could have been any of the green cells, right up to the point of finding the red cell.
image
(play around with it here)

Now, it will find roughly the longest path until it actually reaches the end.

Happy for comments on what exactly we can do for a quick win here to improve the choice mechanism for the A* when it only plans partially.

Verified

This commit was signed with the committer’s verified signature.
sunsided Markus Mayer
Copy link
Member

@Jaeyoung-Lim Jaeyoung-Lim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is great!

An approach I like personally on dealing with partial planning is using intermediate goals on a receding horizon. By selecting the intermediate planner smartly, we can also make the global navigation behavior fairly smart if we add global heuristics on selecting the intermediate goal such as the Next Best View Planner NBVP+goal cost

@jkflying
Copy link
Contributor Author

jkflying commented Feb 5, 2020

SITL test before:
https://logs.px4.io/plot_app?log=323a24ef-8827-4e5e-b6e7-ed24836f3316

After:
https://logs.px4.io/plot_app?log=497302be-9c69-407c-b7e1-dd64dae3eb58

There's definitely an improvement, especially in the occasional odd big 'jump' that doesn't happen anymore.

@LorenzMeier
Copy link
Member

Is this something that helps short-time?

@jkflying
Copy link
Contributor Author

jkflying commented Feb 5, 2020

IMO yes, it needs real-vehicle testing and some more time in SITL though, since it changes the core A* path choice.

@baumanta
Copy link
Contributor

baumanta commented Feb 7, 2020

I flight tested today, no regression found. Also this PR seems to improve roll and pitch rate
master
master
PR
flight2

@baumanta baumanta merged commit 09cb367 into master Feb 7, 2020
@baumanta baumanta deleted the smooth-astar branch February 7, 2020 12:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants