Improvements to the QURT platform message logging facility #24462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t module name is printed both in mini-dm and on apps side terminal
dagar
reviewed
Mar 10, 2025
| @@ -70,48 +70,48 @@ __END_DECLS | |||
| /**************************************************************************** | |||
| * Messages that should never be filtered or compiled out | |||
| ****************************************************************************/ | |||
| #define PX4_INFO(FMT, ...) qurt_log(_PX4_LOG_LEVEL_INFO, __FILE__, __LINE__, FMT, ##__VA_ARGS__) | |||
| #define PX4_INFO(FMT, ...) qurt_log_module(_PX4_LOG_LEVEL_INFO, MODULE_NAME, __FILE__, __LINE__, FMT, ##__VA_ARGS__) | |||
There was a problem hiding this comment.
Maybe stating the obvious, but at some point we should really split this so qurt can provide its own log.h rather than having a central header with platform defines.
dagar
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made general improvements to the QURT platform message logging so that module name is printed both in mini-dm and on apps side terminal. Also some QURT log formatting changes to get rid of extra newlines.