-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
microRTPS: fix UART link #15354
microRTPS: fix UART link #15354
Conversation
edfd098
to
6fcfbb0
Compare
13dfd34
to
43b1152
Compare
@AndrewWedemier thanks for your insights and your debugging effort, which ended-up helping me unblock this! Added you as a co-author in one commit, which was the commit that allows to have the bridge usable over UART. Note that for setups which are to run at baud rates <=1MByte/sec, it's required to throttle the overall publishing using the micrortps_client start -d /dev/ttyS2 -b 1000000 -v -w 6
./micrortps_agent -d /dev/ttyUSB0 -b 1000000 -v -w 6 works nice without any errors, though it introduces some latency on the link. The alternative is also increasing the baud rate. Found that using 1.5MByte/s with the current default streams is enough to have it work properly. micrortps_client start -d /dev/ttyS2 -b 1500000 -v
./micrortps_agent -d /dev/ttyUSB0 -b 1500000 -v Note that with the increase of the number of topics being streamed, and depending on each rates, this might change and might require changes on the stream rates. |
src/modules/micrortps_bridge/micrortps_client/microRTPS_client_main.cpp
Outdated
Show resolved
Hide resolved
c3e515a
to
314d779
Compare
a7112c4
to
2b6fda8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better, thanks.
Can you also cleanup the commits? There should not be revert commits.
… the buffer and continue the readings
…ase the RTTI check on timesync
2b6fda8
to
46d20df
Compare
…ud rate options Co-authored-by: Andrew Wedemier <[email protected]>
…S is grabbed in a colcon build
46d20df
to
548a3aa
Compare
Thanks @bkueng! |
Currently the microRTPS bridge UART link is broken and it's resulting on continuous CRC errors on the agent side that after some seconds close the link. This is being investigated.
Also, it was verified that a stack increase was required to avoid the
micrortps_client
of causing and hardfault and rebooting the flight controller.