Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sensors/vehicle_imu: initially schedule conservatively #15353

Merged
merged 1 commit into from
Jul 20, 2020
Merged

sensors/vehicle_imu: initially schedule conservatively #15353

merged 1 commit into from
Jul 20, 2020

Conversation

dagar
Copy link
Member

@dagar dagar commented Jul 16, 2020

  • this lowers the load immediately at boot while still allowing each VehicleIMU instance to properly measure the actual accel/gyro data rates

@dagar
Copy link
Member Author

dagar commented Jul 16, 2020

Originally this wasn't done because it's important for each VehicleIMU instance to not miss any sensor samples when determining the actual data rate, but now each subscription monitors uORB generation gaps as well.

@dagar dagar requested a review from bkueng July 16, 2020 19:12
@dagar
Copy link
Member Author

dagar commented Jul 16, 2020

Right, of course this makes SITL lockstep unhappy.

@dagar dagar marked this pull request as draft July 16, 2020 19:13
@dagar dagar changed the title sensors/vehicle_imu: initially schedule conservatively [WIP] sensors/vehicle_imu: initially schedule conservatively Jul 16, 2020
@dagar dagar force-pushed the pr-sensors_vehicle_imu branch from e258a5b to e4c030c Compare July 16, 2020 19:17
@dagar
sensors/vehicle_imu: initially schedule conservatively
521d626 
 - this lowers the load immediately at boot while still allowing each
VehicleIMU instance to properly measure the actual accel/gyro data rates
@dagar dagar force-pushed the pr-sensors_vehicle_imu branch from e4c030c to 521d626 Compare July 16, 2020 19:18
@dagar dagar changed the title [WIP] sensors/vehicle_imu: initially schedule conservatively sensors/vehicle_imu: initially schedule conservatively Jul 17, 2020
@dagar dagar marked this pull request as ready for review July 17, 2020 13:48
@weekly-digest weekly-digest bot mentioned this pull request Jul 19, 2020
Closed
@dagar dagar merged commit 2adc23f into master Jul 20, 2020
@dagar dagar deleted the pr-sensors_vehicle_imu branch July 20, 2020 14:05
@weekly-digest weekly-digest bot mentioned this pull request Jul 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkueng bkueng bkueng approved these changes

Assignees
No one assigned
Labels
Admin: Enhancement (improvement) 💡
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dagar @bkueng