commander: fix takeoff and land CI test #15351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the takeoff and land CI test where we do a takeoff and land without RC connected. In my opinion it does not make sense to go into RC lost failsafe if a datalink is still available. Of course, this can be dangerous if someone has a companion computer connected which gets detected as "data link" but actually has no connection to the ground station.
|
This sounds right to me, if anything I'm wondering if this was intentionally not done in the first place. |
|
I wanted to first lock down arming with manual control and data link (depending on configuration and mode), but it's not a small clean change. I'll merge this now and come back to that idea later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the takeoff and land CI test where we do a takeoff and land without RC connected.
In my opinion it does not make sense to go into RC lost failsafe if a datalink is still available.
Of course, this can be dangerous if someone has a companion computer connected which gets detected as "data link" but actually has no connection to the ground station.
This is required for the takeoff and land SITL test after #15316.