mavlink_ftp: close inactive session #15332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianoes
previously approved these changes
Jul 15, 2020
bkueng
reviewed
Jul 16, 2020
10s inactivity timeout to close session
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
10s inactivity timeout to close session (can be corrected to more suitable timeout).
Without this patch if GCS is disconnected during ftp session, vehicle get stuck with not closed session and GCS will not be able to open new session (FTP: Open failed - out of sessions) until vehicle reboot. Another option is for GCS to send kCmdResetSessions before open any new session, but I suppose it is not right solution (but can be implemented in common).
I'm working with custom GCS, I didn't check this with QGC and don't know will it pass ftp checks.