Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore compilation warnings #15323

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Ignore compilation warnings #15323

merged 1 commit into from
Jul 14, 2020

Conversation

xdwgood
Copy link
Contributor

@xdwgood xdwgood commented Jul 14, 2020

Describe problem solved by this pull request

This pr to fix: #15275
more detail : https://px4.slack.com/archives/C0W2KUFFT/p1594711366163700

I found the pr that introduced the problem #15301

Describe your solution
Ignore compilation warnings

Test data / coverage
fixed it on my 16.04

Additional context
@dagar Is this the correct approach? 

@julianoes julianoes requested a review from dagar July 14, 2020 08:34
@dagar
Copy link
Member

dagar commented Jul 14, 2020

@dagar Is this the correct approach? 

Yes for systemcmds/tests. For any non test code I'd want to alter the offending source.

Thanks for fixing this @xdwgood.

@dagar dagar merged commit 49a543e into PX4:master Jul 14, 2020
@xdwgood xdwgood deleted the master branch July 15, 2020 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1.11.0-rc1 build fails (-Werror=unused-but-set-parameter)
2 participants