Add translation of rpm uORB message to Mavlink #14863
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TSC21
requested changes
May 7, 2020
| @@ -1596,6 +1596,7 @@ Mavlink::configure_streams_to_default(const char *configure_single_stream) | |||
| configure_stream_local("PING", 0.1f); | |||
| configure_stream_local("POSITION_TARGET_GLOBAL_INT", 1.0f); | |||
| configure_stream_local("POSITION_TARGET_LOCAL_NED", 1.5f); | |||
| configure_stream_local("RAW_RPM", 2.0f); | |||
There was a problem hiding this comment.
Can you please add as well to MAVLINK_MODE_ONBOARD with an higher rate?
There was a problem hiding this comment.
Message added to MAVLINK_MODE_ONBOARD with 5 Hz rate. It should be enough.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this PR translates uORB rpm message (for example from RPM sensor #14018) to MavLink RAW_RPM message. It is verified that it works.
I have updated the MavLink library. And then I noticed a problem that the names of the existing values in the MAV_FRAME message had changed.
I changed names of values according to their descriptions:
https://github.com/mavlink/mavlink/blob/master/message_definitions/v1.0/common.xml#L879-L919
It comes from this commit mavlink/mavlink@81d7a87