mavlink_log_info: also print PX4_INFO #14848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alternatively we could have logger explicitly grab these. |
|
Here we go again.
|
julianoes
previously approved these changes
May 7, 2020
|
There's already mavlink_and_console_log_info |
Right, I forgot about that one. Do you see distinct use cases that should be preserved (mavlink info with no PX4_INFO)? There actually aren't that many
Does anyone see a reason we shouldn't merge |
Merging is fine with me. |
Done. |
bkueng
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be too much information at first, but it's better than being kept in the dark with what a user would have experienced. This came up when debugging #14825.