-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SITL target for starting airsim #14497
Conversation
That's cool. Does this work on all platforms - and what happens if it is not supported/available? We should add this information to:
We also need to make it clear that the simulation is very heavyweight. @Jaeyoung-Lim @julianoes We currently link to "external" instructions in http://dev.px4.io/master/en/simulation/airsim.html |
@hamishwillee I believe so, but it would be dependent on what gets released on the Airsim side. Once Airsim has a new release and we can check that it is functional, we should move the instructions internally. I guess the instructions are external because we never wrote it down properly? |
The instructions are external because it was developed by microsoft and it was never clear how the work would be maintained. That kind of still isn't clear. If we're going to support this, is there any way to get some basic testing done on CI (e.g. just to check that it can be set up and build successfully?) |
|
|
@hamishwillee I think thats a good point. We should definitely check this in CI. I will see what we can do about this. I think just checking if upstream master works with Airsim properly will be enough |
That's what I'm asking you. The simulator needs to handle it. As it's a TCP connection, it knows then the px4 goes down.
Ok, so changing to a HIL config would not be possible either? |
OK, keep me posted re CI. I'll try track this and think about docs when it is done. Feel free to ping me though in case I miss it. |
@Jaeyoung-Lim this is cool but I'm concerned because the airsim releases on GitHub are outdated and don't support lockstep. The Linux one is so old it crashes due to a "wrong" mavlink message. If we are to support that we also need to have builds or build instructions available, right? |
@julianoes good news, AirSim 1.3.0 just released. |
Looking forward airsim_px4_vision |
@bys1123 Airsim can only support one airframe, which is mapped to iris. This is a limitation coming from airsim |
Thanks for explains. |
Oh that's awesome! |
|
@Jaeyoung-Lim Are you saying we need to update our links to Airsim docs to https://microsoft.github.io/AirSim/px4_sitl/ "now"? Irrespective of other changes in this PR? |
@hamishwillee microsoft/AirSim#2507 . Not related other changes I guess. |
I’m trying to run PX4 1.11 (w/ cygwin toolchain) + AirSim 1.3.0 on windows
my settings.json:
|
@bys1123 I believe that the issue is caused by PX4/PX4-SITL_gazebo-classic#411 |
c654d16
to
b37f150
Compare
This adds a simple way to start a px4 sitl instance together with a unreal airsim environment through a make command. This requires a airsim binary that is released
b37f150
to
24939ac
Compare
Closing as stale |
Describe problem solved by this pull request
Previously, to run Airsim with PX4 SITL both simulations need to be run separately. The steps involve multiple steps and creates confusion always when starting / closing each processes on multiple terminals.
Also, since SITL is run completely independent of Airsim, it is hard to enforce which models were supported or not. Currently only the
iris
model is supported.Describe your solution
This PR sets a make target that automatically starts Airsim when it is stored somewhere as a package. The procedure is as the following.
Blocks
environmentAdditional context
The latest Airsim release does not include the latest lockstep fixes, therefore we need to wait for a new release from the Airsim side. Expected ETA <1 week as of microsoft/AirSim#2477