Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ist8310: remove calibration code #14115

Merged
merged 1 commit into from
Feb 6, 2020
Merged

ist8310: remove calibration code #14115

merged 1 commit into from
Feb 6, 2020

Conversation

bkueng
Copy link
Member

@bkueng bkueng commented Feb 6, 2020

  • it does nothing useful
  • increases boot time by 2 seconds on pixhawk 4 due to a poll timeout:
IST8310 on I2C bus 3 at 0x0e (bus: 100 KHz, max: 400 KHz)
WARN  [ist8310] ERROR: TIMEOUT 2

- it does nothing useful
- increases boot time by 2 seconds on pixhawk 4 due to a poll timeout:
IST8310 on I2C bus 3 at 0x0e (bus: 100 KHz, max: 400 KHz)
WARN  [ist8310] ERROR: TIMEOUT 2
@codecov
Copy link

codecov bot commented Feb 6, 2020

Codecov Report

Merging #14115 into master will decrease coverage by 16.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #14115       +/-   ##
===========================================
- Coverage   54.48%   38.47%   -16.02%     
===========================================
  Files         605      605               
  Lines       51256    51208       -48     
===========================================
- Hits        27929    19701     -8228     
- Misses      23327    31507     +8180
Flag Coverage Δ
#mavsdk ?
#python 6.08% <ø> (+2.92%) ⬆️
#sitl_mission_FW ?
#sitl_mission_MC_box ?
#sitl_mission_MC_offboard_att 100% <ø> (ø) ⬆️
#sitl_mission_MC_offboard_pos ?
#sitl_mission_Rover 100% <ø> (+73.68%) ⬆️
#sitl_mission_VTOL_standard ?
#sitl_mission_VTOL_tailsitter ?
#sitl_python_FW 29.32% <ø> (-70.68%) ⬇️
#sitl_python_MC_box ?
#sitl_python_MC_offboard_att 28.43% <ø> (-0.01%) ⬇️
#sitl_python_MC_offboard_pos 28.84% <ø> (-71.16%) ⬇️
#sitl_python_Rover 100% <ø> (+73.6%) ⬆️
#sitl_python_VTOL_standard 100% <ø> (+66.11%) ⬆️
#sitl_python_VTOL_tailsitter 100% <ø> (+66.1%) ⬆️
#unittest 100% <ø> (+65.24%) ⬆️
Impacted Files Coverage Δ
src/systemcmds/tests/test_bezierQuad.cpp 0% <0%> (-100%) ⬇️
src/lib/controllib/BlockLimitSym.cpp 0% <0%> (-100%) ⬇️
src/modules/navigator/mission_block.h 0% <0%> (-100%) ⬇️
src/systemcmds/tests/test_search_min.cpp 0% <0%> (-100%) ⬇️
src/systemcmds/tests/test_hrt.cpp 0% <0%> (-100%) ⬇️
...c/modules/mavlink/mavlink_tests/mavlink_ftp_test.h 0% <0%> (-100%) ⬇️
src/modules/navigator/takeoff.h 0% <0%> (-100%) ⬇️
src/modules/navigator/land.h 0% <0%> (-100%) ⬇️
...ontrollib/controllib_test/controllib_test_main.cpp 0% <0%> (-100%) ⬇️
src/lib/weather_vane/WeatherVane.cpp 0% <0%> (-100%) ⬇️
... and 264 more

@dagar
Copy link
Member

dagar commented Feb 6, 2020

@dagar dagar merged commit b399698 into master Feb 6, 2020
@dagar dagar deleted the rm_ist8310_mag_calibration branch February 6, 2020 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants