Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replay: remove GPS relative timestamps #14114

Merged
merged 1 commit into from
Feb 7, 2020

Conversation

CarlOlsson
Copy link
Contributor

@CarlOlsson CarlOlsson commented Feb 6, 2020

Replaces #14092

Describe problem solved by this pull request
Solves original issue reported here

Describe your solution
Remove relative timestamps of GPS measurements. The benefit of this is that all GPS data that is logged will actually be published during EKF replay even if the ekf2_timestamps topic has dropouts. The downside is that the accuracy of the measurement timestamps is reduced slightly.

Describe possible alternatives
Publish the GPS data anyway if no relative timestamp is found during replay. The upside would be more accurate time stamping and the downside more data to log

Tests
Here are the relative timestamps of two GPS modules (logged in microseconds / 10)
image
As can be seen the difference from the topic original timestamps is on average ~1 ms. This in comparison to the ~100 ms delay of the GPS measurements themselves should have minimal effect on the replay result.

Here is the dt of the gps topic after replay, PR (top) vs master (bottom). As can be seen the dropouts are significantly reduced
image

And here is the selected GPS module, as can be seen the GPS timeout is no longer triggered in the replayed logfile
image

The PR has been tested on code similar to v1.10.1

Thanks @bkueng for the discussion!

@CarlOlsson CarlOlsson force-pushed the pr-remove_gps_relative_timestamps branch from 5fc2e7a to 822cc76 Compare February 6, 2020 15:41
@CarlOlsson
Copy link
Contributor Author

On a sidenote, publishing any sensor data in replay even if no relative timestamp is found would be great to test since it might robustify replay a lot.
E.g. Here are delta velocity biases from a replayed (top) logfile vs the original
image
As can be seen the output is not the same

Copy link
Member

@bkueng bkueng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's get this in then and see if we can further improve things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants