sensors: filter sample rate calculate with simple interval average instead of perf count #14098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlecoeur
reviewed
Feb 4, 2020
src/modules/sensors/vehicle_acceleration/VehicleAcceleration.cpp
Outdated
Show resolved
Hide resolved
dagar
force-pushed
the
pr-sensors_sample_rate
branch
from
7c08b05 to
da1489a
Compare
…stead of perf count
dagar
force-pushed
the
pr-sensors_sample_rate
branch
from
da1489a to
46aca39
Compare
Codecov Report
@@ Coverage Diff @@
## master #14098 +/- ##
===========================================
- Coverage 53.72% 36.18% -17.54%
===========================================
Files 606 546 -60
Lines 51218 46843 -4375
===========================================
- Hits 27517 16952 -10565
- Misses 23701 29891 +6190
|
I'd like to run it overnight again, but so far I don't see it decreasing over time (rarely changing at all past boot). |
|
All right, let's see |
|
On fmu-v3 there were a few resets over several hours (down ~ 10 Hz, then back up), but if anything I'm surprised it's not more erratic given how overloaded that board is at the moment (many sensors on the same bus, very high cpu load) combined with the questionable sensor oversampling. On fmu-v5 it only changed once at boot. |
jlecoeur
approved these changes
Feb 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The perf counter intervals aren't numerically stable over extended periods (#14046), so are obviously not ideal for automatically setting filter sample rates. Here's a simpler solution.