Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NuttX/nuttx with SDIO fixes #13311

Merged
merged 3 commits into from
Oct 31, 2019
Merged

NuttX/nuttx with SDIO fixes #13311

merged 3 commits into from
Oct 31, 2019

Conversation

davids5
Copy link
Member

@davids5 davids5 commented Oct 29, 2019 •
edited by julianoes
Loading

This PR addressees hangs when the SD card is removed while writing.

Fixes #12071 (comment)
Fixes #13087 (comment)

@PX4/testflights - Please test on FMUv4 and FMUv5

@davids5 davids5 force-pushed the master_SDIO_hang_fix branch from 0d01db3 to 5aef2bb Compare October 29, 2019 20:21
julianoes
julianoes previously approved these changes Oct 30, 2019
View reviewed changes
@julianoes
Copy link
Contributor

This will also need to be cherry-picked into v1.10.

@julianoes
Copy link
Contributor

And thanks @davids5!

@dagar dagar added this to the Release v1.10.0 milestone Oct 30, 2019
@dagar dagar requested a review from a team October 30, 2019 14:15
@jorge789
Copy link

jorge789 commented Oct 30, 2019 •
edited by Tony3dr
Loading

Tested on PixRacer V4:

Indoor test flight
Modes: Stabilize
Notes:
Due to the bad weather, we are not able to do outdoor test flights. We did some indoor test flights, Takeoff in stabilize mode, flew the vehicle for about 1:30 minutes. Good indoor flight no issues.

Log:
https://review.px4.io/plot_app?log=b155d9b0-1d33-4c48-9168-e8b9c903f6b9

https://review.px4.io/plot_app?log=5a8a74d5-1990-4a54-98e1-3218a9c9a91c

@davids5 let us know if the indoor test is useful, to continue testing with the V5.

@dagar
Copy link
Member

dagar commented Oct 31, 2019

PX4/NuttX#68 has merged and I've updated this PR to point to the tip of px4_firmware_nuttx-7.29+.

@julianoes
Copy link
Contributor

I tested this branch in HITL and navigator correctly complains "Waypoint could not be read" and RTL is still possible.

I also checked @BazookaJoe1900's statfs issue. I could reproduce the issue with master but not with this fix, so that's fixed as well.

@julianoes julianoes merged commit a3e2777 into master Oct 31, 2019
@julianoes julianoes deleted the master_SDIO_hang_fix branch October 31, 2019 15:55
julianoes pushed a commit that referenced this pull request Oct 31, 2019
@davids5 @julianoes
NuttX/nuttx with SDIO fixes (#13311)
4543a13 
* NuttX/nuttx with SDIO fixes
@julianoes julianoes mentioned this pull request Oct 31, 2019
Merged
@davids5
Copy link
Member Author

davids5 commented Oct 31, 2019

@julianoes - Thank you for testing it!

dagar pushed a commit that referenced this pull request Oct 31, 2019
@davids5 @dagar
NuttX/nuttx with SDIO fixes (#13311)
5c6d16c 
* NuttX/nuttx with SDIO fixes
This was referenced Nov 4, 2019
Closed
Merged
@BazookaJoe1900
Copy link
Member

@davids5 Thanks!
I have tested it too on my costum branch and the fix seems to work well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagar dagar dagar approved these changes

@julianoes julianoes julianoes left review comments

@BazookaJoe1900 BazookaJoe1900 Awaiting requested review from BazookaJoe1900

Assignees
No one assigned
Labels
bug NuttX (OS)
Projects
None yet
Milestone
Release v1.10.0
Development

Successfully merging this pull request may close these issues.

nuttx - statfs() might lead to halt Custom firmware crash
5 participants
@davids5 @julianoes @jorge789 @dagar @BazookaJoe1900