Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UAVCAN: Optical Flow: Bug fix missing integration_timespan field #13257

Merged
merged 4 commits into from
Oct 25, 2019

Conversation

JacobCrabill
Copy link
Member

@JacobCrabill JacobCrabill commented Oct 23, 2019

…optical_flow topic).

This is pretty straightforward. The uORB topic optical_flow includes a field integration_timespan, which is used within EKF2 (after being copied to the dt field of a flowSample object) for a number of calculations, including for the variable flow_innov. The UAVCAN sensor driver for optical flow devices (HereFlow) did not copy this field to the topic before publishing (but it does exist in the CAN message frame). This resulted in flow_innov always being 0. The fix: copy the field (ensuring consistent units).

@JacobCrabill JacobCrabill changed the title UAVCAN: Optical Flow: Bug fix (missing integration_timespan field in … UAVCAN: Optical Flow: Bug fix missing integration_timespan field Oct 23, 2019
@TSC21
Copy link
Member

TSC21 commented Oct 23, 2019

@JacobCrabill please run make format to fix the style and amend the commit.

@TSC21 TSC21 added this to the Release v1.10.0 milestone Oct 23, 2019
Copy link
Member

@bresch bresch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the rest

@JacobCrabill
Copy link
Member Author

Fixed the formatting issues
Should be all set

@MaEtUgR
Copy link
Member

MaEtUgR commented Oct 23, 2019

@JacobCrabill Just a hint: if you set the git identity on your machine to the mail address you use on GitHub it will assign it to your profile and show the profile picture next to the commit and you'll appear in the GitHub statistics.
e.g. $ git config --global user.email [email protected]

@JacobCrabill
Copy link
Member Author

@MaEtUgR thanks for the tip. We changed domain names at Volans-i a while back and I forgot to update my email address in my account.

@JacobCrabill
Copy link
Member Author

@dagar , @bresch should this be rebased on / merged with the current "beta" branch (v1.10-beta4) instead of master in order to include in the 1.10 release? Or, is the current head of master going to end up in v1.10?

@julianoes
Copy link
Contributor

@JacobCrabill I think we can cherry-pick it into the release branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants