-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UAVCAN: Optical Flow: Bug fix missing integration_timespan field #13257
Conversation
@JacobCrabill please run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for the rest
f50d299
to
d15d1c6
Compare
…optical_flow topic).
d15d1c6
to
6ff8908
Compare
Fixed the formatting issues |
@JacobCrabill Just a hint: if you set the git identity on your machine to the mail address you use on GitHub it will assign it to your profile and show the profile picture next to the commit and you'll appear in the GitHub statistics. |
@MaEtUgR thanks for the tip. We changed domain names at Volans-i a while back and I forgot to update my email address in my account. |
@JacobCrabill I think we can cherry-pick it into the release branch. |
…optical_flow topic). (#13257)
…optical_flow topic).
This is pretty straightforward. The uORB topic
optical_flow
includes a fieldintegration_timespan
, which is used within EKF2 (after being copied to thedt
field of aflowSample
object) for a number of calculations, including for the variableflow_innov
. The UAVCAN sensor driver for optical flow devices (HereFlow) did not copy this field to the topic before publishing (but it does exist in the CAN message frame). This resulted inflow_innov
always being 0. The fix: copy the field (ensuring consistent units).