Delete unnecessary driver #includes continued... #12437
Merged
+260
−617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcsauder
force-pushed
the
delete_unnecessary_includes_continued
branch
from
a0e97c9 to
b1f4f4b
Compare
mcsauder
force-pushed
the
delete_unnecessary_includes_continued
branch
from
b1f4f4b to
c160eb2
Compare
mcsauder
commented
Jul 9, 2019
| #define BATT_SMBUS_SERIAL_NUMBER 0x1C ///< serial number register | ||
| #define BATT_SMBUS_MEASUREMENT_INTERVAL_US 100000 ///< time in microseconds, measure at 10Hz | ||
| #define BATT_SMBUS_TIMEOUT_US 1000000 ///< timeout looking for battery 10seconds after startup | ||
| #include "board_config.h" |
There was a problem hiding this comment.
This was a mix of spaces and tabs... it is uniform now, my apologies for the diff.
dagar
approved these changes
Jul 9, 2019
|
With bloaty on Jenkins we can see there's no change in the fmu-v2 or fmu-v5 binaries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe problem solved by the proposed pull request
There are a lot of unnecessary #includes in the drivers in general. This is a second pass at the driver directory. I have organized most #includes to header files to avoid duplication and make use of the #pragma once preprocessor directive. This is continuation of similar work in PR #12431.
Test data / coverage
No logic was touched in this PR. All builds succeeding in the CI tools is sufficient proof that nothing essential has been deleted.
Additional context
This is mostly janitorial work geared at keeping the code base clean.
Please let me know if you have any questions on this PR. Thanks!
-Mark