-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tiltrotor motors shaking #12240
Comments
I'm guessing this is related to reducing the real-time update rate from 800 to 250 to implement the lock step in the gazebo_mavlink_interface. |
Can confirm, disabling lockstep in the model.sdf and increasing the real-time update rate to 800 (max step size of 0.00125) |
@dlwalter I would like to understand why or how that fixes it. I can see that it might prevent the visible shaking but there still seems to be something going on. |
I agree - I just needed a workaround for now. Looking forward to an update. |
@RomanBapst do you have any idea here? |
I hit the same issue a while ago : my model's hinges were completely unstable. If I remember correctly, setting a larger number of iterations fixed it. |
Ok, to me this sounds like we need to enable higher real time update rates again and make them work with lockstep. |
This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions. |
Yes, disabling lockstep and setting real_time_update_rate to 500 and max_step_size to 0.002 helped to get rid of motor shaking in disarmed state and made the flight much more stable (especially the transitions were very unstable before). Has anybody an idea what the root cause could be? |
This is fixed by PX4/PX4-SITL_gazebo-classic#386 no? Or are we still looking for the root cause and a more global fix? P.s. I didn't test it, just linking the issues/PRs |
For me it fixed the shaking of the tilt, but not really lead to a more stable flight (mainly transitions). There only setting real_time_update_rate to 500 and max_step_size to 0.002 solved it. Wondering if it's also the case for other users. |
@sfuhrer how can you "see" the more stable flight with higher update rate? |
This is with the default settings (lockstep enabled, rate at 250 and step at 0.004): |
Shouldn’t we be able to just ramp up the sample rate also in lockstep? |
That might "just" work. I'll try it and see what else depends on this rate. It will likely increase CPU and decrease the max possible sim speedup that is possible. |
The "just" is not so straightforward because if we change the default update rate it means that all models in all submodules for Gazebo and jMAVSim, would have to be changed, so it's quite a bit of churn. The more long term solution would be to support varying sample rates while still staying in lockstep. |
@julianoes I think this is something occuring commonly with position controlled joints in gazebo(also observed on the gimbal on the h480. I will try to see if I can tune the joint control better |
@sfuhrer it would be good if you could test tiltrotor with this wip branch: It raises the rate from 250 Hz to 500 Hz. I want to confirm if this actually fixes the issue or if the issue is something about lockstep and not the rate itself. Btw. iris speedup in Gazebo decreases from 25x to 11x when doubling the rate. Presumably, we could optimize this with optimizations like pipelining the messages, so we don't have to wait on the roundtrip of messages each time but can free-wheel to a certain extent. |
@LorenzMeier ok this turns out to be a bit more complex. Doubling the rate is trivial for multicopter which run at the gyro rate. For VTOL, it falls apart right after the transition when we switch to fixedwing control which runs at the ekf2 rate, so probably 250 Hz. I'll think about potential ways to work around this. |
@sfuhrer ok please fetch this branch again to test. Gazebo now runs at 500 Hz but everything with PX4 is only transmitted at 250 Hz. |
Yes it now looks good 👍 👍 |
PR is done: PX4/PX4-SITL_gazebo-classic#415 |
With PX4/PX4-SITL_gazebo-classic#415 the tiltrotor sitl problems (both shaking and unsteady transitions) seem to be solved, so I'm gonna close this. |
When disarmed, the motors of the tiltrotor shake in tiltrotor SITL.
To reproduce:
The shaking goes away when you do:
but re-appears after:
FYI @sfuhrer
@dlwalter raised the issue in https://discuss.px4.io/t/gazebo-tiltrotor-model-joints-are-shaking-in-1-9-0/11355/2.
The text was updated successfully, but these errors were encountered: