Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0] prettier-xml: A little bit too invasive #34

Closed
rousseldenis opened this issue Oct 26, 2020 · 2 comments · Fixed by #35
Closed

[14.0] prettier-xml: A little bit too invasive #34

rousseldenis opened this issue Oct 26, 2020 · 2 comments · Fixed by #35

Comments

@rousseldenis
Copy link
Contributor

I had issue with a report : https://travis-ci.com/github/OCA/event/jobs/406980086#L369

prettier-xml is adding carriage return to xml values. In that case, this is annoying as Odoo does not trim, so when installing, the reference to the report is not found.

Values shouldn't be modified.
@pedrobaeza
Copy link
Member

Another similar case:

OCA/community-data-files#99 (comment)

It seems this needs to put the prettier xml as strict.

cc @yajo @sbidoul

yajo added a commit that referenced this issue Oct 26, 2020
@yajo
Use strict mode in prettier xml plugin
4f3515e 
This will make XML files be less pretty, but also less surprising.

Fix #34.
@yajo yajo mentioned this issue Oct 26, 2020
Merged
@yajo
Copy link
Member

yajo commented Oct 26, 2020

Fix in #35.

@rousseldenis rousseldenis mentioned this issue Oct 26, 2020
Closed
@rvalyi rvalyi mentioned this issue Nov 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use strict mode in prettier xml plugin OCA/oca-addons-repo-template
3 participants
@yajo @pedrobaeza @rousseldenis