14.0 mig crm phonecall #361

redapureskill · 2020-10-26T14:45:54Z

Migrating crm_phonecall to from V13 to V14.

* crm_phonecall module (#131) This module is the part extracted from Odoo v8 crm module from Odoo that allows to record phone calls. As it has been stripped off from Odoo v9, we add again the feature via this module. Migration scripts are also included to upgrade a v8 database via OpenUpgrade and don't lose your history. * [MIG] crm_phone_call: Migrated to 10.0 - FIX: Correct some lint errors * [MIG] crm_phone_call: Migrated to 10.0

…reated from phonecall2phonecall wizard.

…ut `date`

Currently translated at 100.0% (150 of 150 strings) Translation: crm-12.0/crm-12.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/es/

Currently translated at 86.0% (129 of 150 strings) Translation: crm-12.0/crm-12.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/de/

…ve_id is not correct

Currently translated at 92.7% (139 of 150 strings) Translation: crm-12.0/crm-12.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/de/

Currently translated at 98.0% (147 of 150 strings) Translation: crm-12.0/crm-12.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/de/

Currently translated at 27.3% (41 of 150 strings) Translation: crm-12.0/crm-12.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/hr/

Currently translated at 41.3% (62 of 150 strings) Translation: crm-12.0/crm-12.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/hr/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: crm-13.0/crm-13.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-13-0/crm-13-0-crm_phonecall/

…bally from crm settings.

…change name to all groups for consistancy.

Currently translated at 100.0% (161 of 161 strings) Translation: crm-13.0/crm-13.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-13-0/crm-13-0-crm_phonecall/es_AR/

The Phonecall form's statusbar is intended to be clickable, but Odoo 13 is apparently no longer compatible with clickable="True". Instead, either clickable="1" or options="{'clickable': 1}" must be used. Odoo core code uses the latter, so the Claim form has been updated to match core convention.

Currently translated at 100.0% (161 of 161 strings) Translation: crm-13.0/crm-13.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-13-0/crm-13-0-crm_phonecall/es_AR/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: crm-13.0/crm-13.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-13-0/crm-13-0-crm_phonecall/

Currently translated at 100.0% (161 of 161 strings) Translation: crm-13.0/crm-13.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-13-0/crm-13-0-crm_phonecall/es_AR/

rousseldenis · 2020-10-26T15:02:50Z

.pre-commit-config.yaml

@@ -48,6 +48,7 @@ repos:
          - "@prettier/[email protected]"
        args:
          - --plugin=@prettier/plugin-xml
+        files: \.xml$


Why changing this?

was giving me error on prettier and xml plugin in pre-commit, when i added it, it worked 👍

rousseldenis

Hi @redapureskill, thank you for your contribution. Could you adapt your code ?

rousseldenis · 2020-10-26T15:03:08Z

crm_phonecall/__manifest__.py

@@ -1,11 +1,10 @@
-# Copyright 2017 Tecnativa - Vicent Cubells


You cannot remove authorship

sure my bad

rousseldenis · 2020-10-26T15:03:22Z

crm_phonecall/__manifest__.py

    "category": "Customer Relationship Management",
-    "author": "Odoo S.A., Tecnativa, Odoo Community Association (OCA)",
+    "author": "Odoo Community Association (OCA)",


git was showing problem with "no Odoo Community Association (OCA)" author found in manifest.
i'll fix it

rousseldenis · 2020-10-26T15:08:19Z

setup/crm_phonecall/odoo/addons/crm_phonecall/crm_phonecall

@@ -0,0 +1 @@
+../../../../crm_phonecall


Mmmh, I think your link is not good (see Travis error). Did you use setuptools-odoo-make-default ?

i was getting this erreur when i do it :
OSError: [WinError 1314] Le client ne dispose pas d'un privilège nécessaire: '..\..\..\..\crm_phonecall' -> '.\setup\crm_phonecall\odoo\addons\crm_phonecall'
i tried with administrator same thing.

pedrobaeza · 2020-10-26T15:56:56Z

Are you developing in Windows? If so, that's the problem I'm afraid.

redapureskill

Windows and docker

redapureskill · 2020-10-26T15:58:27Z

.pre-commit-config.yaml

@@ -48,6 +48,7 @@ repos:
          - "@prettier/[email protected]"
        args:
          - --plugin=@prettier/plugin-xml
+        files: \.xml$


was giving me error on prettier and xml plugin in pre-commit, when i added it, it worked 👍

pedrobaeza · 2020-10-26T16:06:01Z

I think the flow is not well supported by Windows, as there's no symbolic link option there.

rousseldenis · 2020-10-26T16:08:27Z

@redapureskill The prettier problem should almost be changed in a separate commit (and best in another PR). As prettier for xml is quite new in OCA, I suggest you to point out what's going wrong (with error message) and take a look there OCA/oca-addons-repo-template#34 if it is not the problem you have.

redapureskill · 2020-10-27T13:32:51Z

Generate default setup.py for an addons directory........................Failed

hook id: setuptools-odoo-make-default
exit code: 1

Traceback (most recent call last):
File "C:\Users\y.yahla\AppData\Local\Programs\Python\Python39\lib\runpy.py", line 197, in _run_module_as_main
return _run_code(code, main_globals, None,
File "C:\Users\y.yahla\AppData\Local\Programs\Python\Python39\lib\runpy.py", line 87, in run_code
exec(code, run_globals)
File "C:\Users\y.yahla.cache\pre-commit\repo_uveda\py_env-python3\Scripts\setuptools-odoo-make-default.EXE_main.py", line 7, in
File "c:\users\y.yahla.cache\pre-commit\repo_uveda\py_env-python3\lib\site-packages\setuptools_odoo\make_default_setup.py", line 397, in main
make_default_setup_addons_dir(
File "c:\users\y.yahla.cache\pre-commit\repo_uveda\py_env-python3\lib\site-packages\setuptools_odoo\make_default_setup.py", line 151, in make_default_setup_addons_dir
make_default_setup_addon(
File "c:\users\y.yahla.cache\pre-commit\repo_uveda\py_env-python3\lib\site-packages\setuptools_odoo\make_default_setup.py", line 121, in make_default_setup_addon
os.symlink(os.path.relpath(addon_dir, odoo_addons_path), link_path)
OSError: [WinError 1314] Le client ne dispose pas d'un privilège nécessaire: '..\..\..\..\crm_phonecall' -> '.\setup\crm_phonecall\odoo\addons\crm_phonecall'

redapureskill · 2020-10-27T13:33:29Z

Generate default setup.py for an addons directory........................Failed

hook id: setuptools-odoo-make-default

exit code: 1

Traceback (most recent call last):
File "C:\Users\y.yahla\AppData\Local\Programs\Python\Python39\lib\runpy.py", line 197, in _run_module_as_main
return run_code(code, main_globals, None,
File "C:\Users\y.yahla\AppData\Local\Programs\Python\Python39\lib\runpy.py", line 87, in run_code exec(code, run_globals) File "C:\Users\y.yahla.cache\pre-commit\repo_uveda\py_env-python3\Scripts\setuptools-odoo-make-default.EXE__main.py", line 7, in
File "c:\users\y.yahla.cache\pre-commit\repo_uveda\py_env-python3\lib\site-packages\setuptools_odoo\make_default_setup.py", line 397, in main
make_default_setup_addons_dir(
File "c:\users\y.yahla.cache\pre-commit\repo_uveda\py_env-python3\lib\site-packages\setuptools_odoo\make_default_setup.py", line 151, in make_default_setup_addons_dir
make_default_setup_addon(
File "c:\users\y.yahla.cache\pre-commit\repo_uveda\py_env-python3\lib\site-packages\setuptools_odoo\make_default_setup.py", line 121, in make_default_setup_addon
os.symlink(os.path.relpath(addon_dir, odoo_addons_path), link_path)
OSError: [WinError 1314] Le client ne dispose pas d'un privilège nécessaire: '........\crm_phonecall' -> '.\setup\crm_phonecall\odoo\addons\crm_phonecall'

this is what's stopping me rn :'(

pedrobaeza · 2020-10-27T13:36:25Z

It seems you are forced to develop in Linux.

redapureskill · 2020-10-27T13:37:59Z

It seems you are forced to develop in Linux.

i wonder if there's a docker image with git+python ?

pedrobaeza · 2020-10-27T13:39:22Z

Well, I think a base Ubuntu Docker image should be enough for having the proper stack, but I recommend you that if you are going to be serious in this Odoo world, to fully switch to Linux in your development environment.

redapureskill · 2020-10-27T13:48:03Z

i am, and i'll be switching to linux ,
thank you pedro

redapureskill · 2020-10-28T10:08:06Z

on linux, i'm getting errors on shebangs in pre-commit 👍
Check that executables have shebangs.....................................Failed

hook id: check-executables-have-shebangs
exit code: 1

crm_phonecall/report/crm_phonecall_report_view.xml: marked executable but has no (or invalid) shebang!
If it isn't supposed to be executable, try: chmod -x crm_phonecall/report/crm_phonecall_report_view.xml
If it is supposed to be executable, double-check its shebang.
...

and

pylint with mandatory checks.............................................Failed

hook id: pylint
exit code: 4

************* Module crm_phonecall.report.init
crm_phonecall/report/init.py:1: [W8201(incoherent-interpreter-exec-perm), ] You have a python file with execution permissions but you don't have an interpreter magic comment, or a magic comment but no execution permission. If you really needs a execution permission then add a magic comment ( https://en.wikipedia.org/wiki/Shebang_(Unix) ). If you don't needs a execution permission then remove it with: chmod -x init.py
...

pedrobaeza · 2020-10-28T10:12:36Z

Are you sharing the files through NTFS or similar (or copied from them)? The +x attribute is not allowed in Windows like filesystems, and then Linux put to all of them this flag by default. You should clone the repo directly on Linux or change these attributes.

redapureskill · 2020-10-28T10:18:05Z

i tried changing the attributes using chmod -x but still same errors.

pedrobaeza · 2020-10-28T10:20:25Z

As said, it seems you are under a Window filesystem.

redapureskill · 2020-11-05T21:11:17Z

Should be ok in #364

cubells and others added 30 commits October 26, 2020 15:38

[IMP] Add smartbutton to leads and opportunities

62f7ad4

[IMP][crm_phonecall] Add utm.mixin fields

7d6c727

crm_phonecall: Fix action to redirect to the new phonecall when its c…

298b2f6

…reated from phonecall2phonecall wizard.

[FIX] crm_phonecall: C8108(method-compute) + E8103(sql-injection)

9226660

[MIG] crm_phonecall: Migration to 11.0

5b8bc00

crm_phonecall: fixes to skip duration computation on phonecalls witho…

9134e4b

…ut `date`

[MIG] crm_phonecall: Migration to 12.0.

63bdcac

Translated using Weblate (Spanish)

c7abdcc

Currently translated at 100.0% (150 of 150 strings) Translation: crm-12.0/crm-12.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/es/

Translated using Weblate (German)

36a8990

Currently translated at 86.0% (129 of 150 strings) Translation: crm-12.0/crm-12.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/de/

[FIX] crm_phonecall: make states editable

2b1f139

[FIX] crm_phonecall: when accessing from partner's opportunities acti…

fef0290

…ve_id is not correct

Translated using Weblate (German)

3555dfd

Currently translated at 92.7% (139 of 150 strings) Translation: crm-12.0/crm-12.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/de/

Translated using Weblate (German)

f37681d

Currently translated at 98.0% (147 of 150 strings) Translation: crm-12.0/crm-12.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/de/

[FIX] crm_phonecall button size

9902211

Translated using Weblate (Croatian)

5b54c85

Currently translated at 27.3% (41 of 150 strings) Translation: crm-12.0/crm-12.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/hr/

[IMP] crm_phonecall UI Phonecall button next to Meetings

68a6605

Translated using Weblate (Croatian)

b620696

Currently translated at 41.3% (62 of 150 strings) Translation: crm-12.0/crm-12.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/hr/

[IMP] crm_phonecall: black, isort

e76e7e3

[MIG] crm_phonecall: Migration to 13.0

3c9957b

[UPD] Update crm_phonecall.pot

f1160a9

pre-commit update

670a9f5

Update translation files

e50b7d9

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: crm-13.0/crm-13.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-13-0/crm-13-0-crm_phonecall/

[IMP] crm_phonecall: Add field direction in calls and improve views.

bf61a5d

[IMP] crm_phonecall: Add new group to enable form view for phone calls.

2357749

[IMP] crm_phonecall: Add field direction in tree view of phone calls.

a955fd6

[IMP] crm_phonecall: Add config setting to allow enable form view glo…

51e654c

…bally from crm settings.

[FIX] crm_phonecall: Fix group by state in search view of calls, and …

9d178ed

…change name to all groups for consistancy.

[UPD] Update crm_phonecall.pot

68aa66c

[UPD] README.rst

c7ca6c0

ibuioli and others added 7 commits October 26, 2020 15:38

Translated using Weblate (Spanish (Argentina))

ba01dbe

Currently translated at 100.0% (161 of 161 strings) Translation: crm-13.0/crm-13.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-13-0/crm-13-0-crm_phonecall/es_AR/

crm_phonecall 13.0.1.2.2

70b4b0a

Translated using Weblate (Spanish (Argentina))

6321d4c

Currently translated at 100.0% (161 of 161 strings) Translation: crm-13.0/crm-13.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-13-0/crm-13-0-crm_phonecall/es_AR/

Update translation files

84bc1f3

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: crm-13.0/crm-13.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-13-0/crm-13-0-crm_phonecall/

Translated using Weblate (Spanish (Argentina))

14ed209

Currently translated at 100.0% (161 of 161 strings) Translation: crm-13.0/crm-13.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-13-0/crm-13-0-crm_phonecall/es_AR/

[MIG] crm_phonecall: Migration to 14.0

113f254

rousseldenis added migration needs review labels Oct 26, 2020

rousseldenis added this to the 14.0 milestone Oct 26, 2020

rousseldenis mentioned this pull request Oct 26, 2020

Migration to version 14.0 #356

Closed

17 tasks

rousseldenis reviewed Oct 26, 2020

View reviewed changes

rousseldenis requested changes Oct 26, 2020

View reviewed changes

Update manifest

685b8e4

redapureskill commented Oct 26, 2020

View reviewed changes

redapureskill closed this Nov 5, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

14.0 mig crm phonecall #361

14.0 mig crm phonecall #361

redapureskill commented Oct 26, 2020

rousseldenis Oct 26, 2020

redapureskill Oct 26, 2020

rousseldenis left a comment

rousseldenis Oct 26, 2020

redapureskill Oct 26, 2020

rousseldenis Oct 26, 2020

redapureskill Oct 26, 2020

rousseldenis Oct 26, 2020

redapureskill Oct 26, 2020

pedrobaeza commented Oct 26, 2020

redapureskill left a comment

redapureskill Oct 26, 2020

pedrobaeza commented Oct 26, 2020

rousseldenis commented Oct 26, 2020

redapureskill commented Oct 27, 2020

redapureskill commented Oct 27, 2020

pedrobaeza commented Oct 27, 2020

redapureskill commented Oct 27, 2020

pedrobaeza commented Oct 27, 2020

redapureskill commented Oct 27, 2020

redapureskill commented Oct 28, 2020

pedrobaeza commented Oct 28, 2020

redapureskill commented Oct 28, 2020

pedrobaeza commented Oct 28, 2020

redapureskill commented Nov 5, 2020

		@@ -1,11 +1,10 @@
		# Copyright 2017 Tecnativa - Vicent Cubells

		@@ -0,0 +1 @@
		../../../../crm_phonecall

14.0 mig crm phonecall #361

14.0 mig crm phonecall #361

Conversation

redapureskill commented Oct 26, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rousseldenis left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedrobaeza commented Oct 26, 2020

redapureskill left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedrobaeza commented Oct 26, 2020

rousseldenis commented Oct 26, 2020

redapureskill commented Oct 27, 2020

redapureskill commented Oct 27, 2020

pedrobaeza commented Oct 27, 2020

redapureskill commented Oct 27, 2020

pedrobaeza commented Oct 27, 2020

redapureskill commented Oct 27, 2020

redapureskill commented Oct 28, 2020

pedrobaeza commented Oct 28, 2020

redapureskill commented Oct 28, 2020

pedrobaeza commented Oct 28, 2020

redapureskill commented Nov 5, 2020