[MIG] crm_claim: Migration to 14.0 #370

redapureskill · 2020-11-15T16:19:08Z

Migrating crm_claim from V13 to V14:

#TODO Change version in manifest.py file : Done.
#TODO Migration process file crm_claim.data : {
crm_claim_data.xml : Done.
} : Done.
#TODO Migration process file crm_claim.demo : {
crm_claim_demo.xml : Done.
} : Done.
#TODO Migration process file crm_claim.models : {
crm_claim.py : Done.
crm_claim_category.py : Done.
crm_claim_stage.py : Done.
res_partner.py : Done.

} : Done
#TODO Migration process file crm_claim.report : {
crm_claim_report.py : Done.
crm_claim_report_view.xml : Done.
}: Done.
#TODO Migration process file crm_claim.tests : Done.
#TODO Migration process file crm_claim.report :{
crm_claim_view.xml : Done.
crm_claim_category_view.xml : Done.
crm_claim_stage_view.xml : Done.
res_partner_view.xml : Done.
}: Done.

Include record rule for multi-company.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: crm-13.0/crm-13.0-crm_claim Translate-URL: https://translation.odoo-community.org/projects/crm-13-0/crm-13-0-crm_claim/

The Claim form's statusbar is intended to be clickable, but Odoo 13 is apparently no longer compatible with `clickable="True"`. Instead, either `clickable="1"` or `options="{'clickable': 1}"` must be used. Odoo core code uses the latter, so the Claim form has been updated to match core convention.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: crm-13.0/crm-13.0-crm_claim Translate-URL: https://translation.odoo-community.org/projects/crm-13-0/crm-13-0-crm_claim/

skeller1

👍 LGTM code and functional review locally (runbot is not working at the moment)

Maybe one wish: adding ondelete="restrict" to stage_id and categ_id fields in crm.claim model to prevent information loss. but this is not blocking.

Thank you for supporting OCA

skeller1 · 2021-01-02T11:16:46Z

crm_claim/__manifest__.py

+    "name": "Claims Management",
+    "version": "14.0.1.0.0",
+    "category": "Customer Relationship Management",
+    "author": "Odoo S.A., " "Tecnativa, " "Odoo Community Association (OCA)",


Odoo S.A., " "Tecnativa, " "Odoo Community Association (OCA) => Odoo S.A., Tecnativa, Odoo Community

skeller1 · 2021-01-02T11:47:16Z

crm_claim/README.rst

+
+To configure this module, you need to:
+
+* Go to new menu **CRM > Configuration > Claim > Categories** and create as


maybe we could add the information that we have to do this in debug mode

skeller1 · 2021-01-02T12:05:01Z

crm_claim/views/crm_claim_category_views.xml

+            </p>
+            <p>
+            Create claim categories to better manage and classify your
+            claims. Some example of claims can be: preventive action,


Maybe i am wrong: examples instead of example

Reyes4711-S73 · 2021-03-12T09:48:03Z

Functional review

dsolanki-initos · 2021-03-17T10:46:03Z

crm_claim/views/crm_claim_views.xml

-                <field name="date_deadline" attrs="{'invisible': [(1, '=', 1)]}" />
-                <field name="date_closed" attrs="{'invisible': [(1, '=', 1)]}" />
-                <field name="company_id" groups="base.group_multi_company" />
+                <field attrs="{'invisible': [(1, '=', 1)]}" name="date_deadline" />


Why we need to change this?

And I don't think it works properly. It shows only header, without data, it does not make any sense.

dsolanki-initos · 2021-03-17T10:48:15Z

crm_claim/views/crm_claim_views.xml

                    />
                </header>
                <sheet string="Claims">
                    <group>
                        <field name="name" />
                        <field name="date" />
-                        <field name="company_id" groups="base.group_multi_company" />
+                        <field groups="base.group_multi_company" name="company_id" />


Is it mentioned somewhere to use groups first and then name?

dsolanki-initos · 2021-03-17T10:51:32Z

crm_claim/__manifest__.py

@@ -7,7 +7,7 @@
    "name": "Claims Management",
    "version": "14.0.1.0.0",
    "category": "Customer Relationship Management",
-    "author": "Odoo S.A., Tecnativa, Odoo Community",
+    "author": "Odoo Community Association (OCA)",


Why authors are removed?

@redapureskill Please restore Odoo SA and Tecnativa as authors. Then I could merge this.

@NL66278 This changes among others are done in this #391

@Daniel-CA I do not quite understand what you mean with the reference to the other PR. We should not just delete authors...

Please review the other PR as superseding this one.

OCA-git-bot · 2021-03-30T07:26:13Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

claudiagn

functional review ok! LGTM

simahawk

as per #368 fix the build first 🙏

anajuaristi · 2021-04-12T08:17:35Z

Hello
@simahawk #368 is related to crm_lead and this is crm_claim, so they are different objects. Am I missing something?

On the other side, I tested functionally crm_claim on V14 and LGTM 👍

simahawk · 2021-04-12T15:02:47Z

Hello
@simahawk #368 is related to crm_lead and this is crm_claim, so they are different objects. Am I missing something?

On the other side, I tested functionally crm_claim on V14 and LGTM +1

Ciao Ana! :)

I know but the point is that nobody will be able to merge PR till that issue is gone.

oihane · 2021-04-13T11:41:07Z

Hello
@simahawk #368 is related to crm_lead and this is crm_claim, so they are different objects. Am I missing something?
On the other side, I tested functionally crm_claim on V14 and LGTM +1

Ciao Ana! :)

I know but the point is that nobody will be able to merge PR till that issue is gone.

fix done in #388

redapureskill · 2021-04-13T12:33:43Z

Hello
@simahawk #368 is related to crm_lead and this is crm_claim, so they are different objects. Am I missing something?
On the other side, I tested functionally crm_claim on V14 and LGTM +1

Ciao Ana! :)
I know but the point is that nobody will be able to merge PR till that issue is gone.

fix done in #388

still some checks not successfull please check #388

Daniel-CA · 2021-04-13T12:55:51Z

@redapureskill You should check too @dsolanki-initos stated

oihane · 2021-04-14T08:31:06Z

@redapureskill you should rebase, even there was a check in red, was a minor problem because there was no report to compare with.

anajuaristi · 2021-04-15T07:57:43Z

Hello, is important you make rebase to Travis be able to pass.
It would be great if we could merge this ASAP

dsolanki-initos · 2021-04-23T11:27:49Z

It would be great if this PR is merged.

simahawk · 2021-04-23T12:21:00Z

@dsolanki-initos @redapureskill someone has to rebase it 😉

dsolanki-initos · 2021-04-30T07:34:14Z

Hi @redapureskill it would be great if you could rebase it so that this PR can be merged .

dsolanki-initos · 2021-05-07T09:11:24Z

Hi @redapureskill is it possible to rebase? we need to merge it ASAP.

dsolanki-initos · 2021-05-13T07:15:11Z

Hi @redapureskill can you please rebase as we need to merge it ASAP.

anajuaristi · 2021-05-13T07:22:28Z

@dsolanki-initos @simahawk @oihane @Daniel-CA

Hi tech people. I think @redapureskill is not reading the messages or he is too busy to go on with this. I propose to make a manual merge ourselves.
Please comment if it's possible and if you consider it would be right if we do it.
Thank you!
Ana

Daniel-CA · 2021-05-13T09:23:09Z

I have done another PR with last fixes and updated. #391

redapureskill · 2021-05-31T09:38:17Z

Hi @redapureskill can you please rebase as we need to merge it ASAP.

fixed and rebased, sorry mom passed away!

redapureskill · 2021-05-31T13:51:59Z

LGTM

dsolanki-initos · 2021-06-04T12:06:22Z

Seems that PR is Ready to merge It would be great if it could merged

pedrobaeza · 2021-06-07T07:39:08Z

Superseded by #391

cubells and others added 19 commits November 15, 2020 15:47

[MIG] crm_claim: Migration to 10.0

7ac2438

[10.0][ENH] crm_claim (OCA#178)

57e4cad

[MIG] crm_claim: Migration to 11.0

c49d038

[11.0][IMP] crm_claim: add activities to claims (OCA#214)

9a803da

[MIG] crm_phonecall_summary_predefined: Migration to 11.0

9546afb

Fix default date

e4804ff

[MIG] crm_claim: Migration to v12

00322c1

[FIX] crm_claim: Lint error was fixed

a338082

Update crm_claim_report.py

d5d4ea0

[IMP] crm_claim: Multi-company

6ea0d9d

Include record rule for multi-company.

[IMP] crm_claim: black, isort

8e6e398

Migration 13.0

d3b67a5

[UPD] Update crm_claim.pot

2081145

[UPD] README.rst

477430f

Update translation files

70c26b1

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: crm-13.0/crm-13.0-crm_claim Translate-URL: https://translation.odoo-community.org/projects/crm-13-0/crm-13-0-crm_claim/

crm_claim 13.0.1.0.1

c8fa568

Update translation files

8cf83bb

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: crm-13.0/crm-13.0-crm_claim Translate-URL: https://translation.odoo-community.org/projects/crm-13-0/crm-13-0-crm_claim/

[IMP] crm_claim: black, isort, prettier

0e1ad4d

This was referenced Nov 15, 2020

14.0 mig crm claim type #371

Closed

Migration to version 14.0 #356

Closed

skeller1 approved these changes Jan 2, 2021

View reviewed changes

Reyes4711-S73 mentioned this pull request Mar 8, 2021

[MIG] crm_claim_code: Migration to 14.0 #383

Merged

dsolanki-initos reviewed Mar 17, 2021

View reviewed changes

Reyes4711-S73 approved these changes Mar 18, 2021

View reviewed changes

OCA-git-bot added the approved label Mar 18, 2021

OCA-git-bot added the ready to merge label Mar 30, 2021

claudiagn approved these changes Mar 30, 2021

View reviewed changes

redapureskill force-pushed the 14.0-mig-crm_claim branch from ec518c2 to f7328dd Compare April 7, 2021 08:38

simahawk requested changes Apr 8, 2021

View reviewed changes

OCA-git-bot removed approved ready to merge labels Apr 8, 2021

simahawk changed the title ~~14.0 mig crm claim~~ [MIG] crm_claim: Migration to 14.0 Apr 12, 2021

Daniel-CA mentioned this pull request May 13, 2021

[14.0][MIG] crm_claim: Migration to 14.0 #391

Merged

[MIG] crm_claim: Migration to 14.0

a053000

redapureskill force-pushed the 14.0-mig-crm_claim branch from f7328dd to a053000 Compare May 31, 2021 09:13

redapureskill requested a review from simahawk June 2, 2021 09:11

pedrobaeza closed this Jun 7, 2021

redapureskill deleted the 14.0-mig-crm_claim branch June 7, 2021 07:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG] crm_claim: Migration to 14.0 #370

[MIG] crm_claim: Migration to 14.0 #370

redapureskill commented Nov 15, 2020

skeller1 left a comment •

edited

Loading

skeller1 Jan 2, 2021

skeller1 Jan 2, 2021

skeller1 Jan 2, 2021

Reyes4711-S73 commented Mar 12, 2021

dsolanki-initos Mar 17, 2021

oihane Apr 26, 2021

dsolanki-initos Mar 17, 2021

dsolanki-initos Mar 17, 2021

NL66278 Jun 4, 2021

Daniel-CA Jun 7, 2021

NL66278 Jun 7, 2021

pedrobaeza Jun 7, 2021

OCA-git-bot commented Mar 30, 2021

claudiagn left a comment

simahawk left a comment

anajuaristi commented Apr 12, 2021

simahawk commented Apr 12, 2021 •

edited

Loading

oihane commented Apr 13, 2021

redapureskill commented Apr 13, 2021

Daniel-CA commented Apr 13, 2021

oihane commented Apr 14, 2021

anajuaristi commented Apr 15, 2021

dsolanki-initos commented Apr 23, 2021

simahawk commented Apr 23, 2021

dsolanki-initos commented Apr 30, 2021

dsolanki-initos commented May 7, 2021

dsolanki-initos commented May 13, 2021

anajuaristi commented May 13, 2021

Daniel-CA commented May 13, 2021

redapureskill commented May 31, 2021

redapureskill commented May 31, 2021

dsolanki-initos commented Jun 4, 2021

pedrobaeza commented Jun 7, 2021


		To configure this module, you need to:

		* Go to new menu CRM > Configuration > Claim > Categories and create as

[MIG] crm_claim: Migration to 14.0 #370

[MIG] crm_claim: Migration to 14.0 #370

Conversation

redapureskill commented Nov 15, 2020

Migrating crm_claim from V13 to V14:

skeller1 left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Reyes4711-S73 commented Mar 12, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OCA-git-bot commented Mar 30, 2021

claudiagn left a comment

Choose a reason for hiding this comment

simahawk left a comment

Choose a reason for hiding this comment

anajuaristi commented Apr 12, 2021

simahawk commented Apr 12, 2021 • edited Loading

oihane commented Apr 13, 2021

redapureskill commented Apr 13, 2021

Daniel-CA commented Apr 13, 2021

oihane commented Apr 14, 2021

anajuaristi commented Apr 15, 2021

dsolanki-initos commented Apr 23, 2021

simahawk commented Apr 23, 2021

dsolanki-initos commented Apr 30, 2021

dsolanki-initos commented May 7, 2021

dsolanki-initos commented May 13, 2021

anajuaristi commented May 13, 2021

Daniel-CA commented May 13, 2021

redapureskill commented May 31, 2021

redapureskill commented May 31, 2021

dsolanki-initos commented Jun 4, 2021

pedrobaeza commented Jun 7, 2021

skeller1 left a comment •

edited

Loading

simahawk commented Apr 12, 2021 •

edited

Loading