[10.0][ENH] crm_claim #178
Conversation
|
And not only that, you should make a PR to our branch, not a full new PR. Closing this. |
|
Sorry, the module was merged and it was incorrectly closed. I reopen, but please, don't make any stylistic change (that it's also against OCA guidelines). |
crm_claim/__init__.py
Outdated
| from . import ( | ||
| models, | ||
| report, | ||
| ) |
There was a problem hiding this comment.
Please, delete this change, because I have some scripts that runs over __init__ files and I don't want to change them just because you want to use this kind of notation that nobody uses.
There was a problem hiding this comment.
Although I agree on not changing this to reduce diff, not sure what scripts do you have but those are wrong indeed, this is perfectly valid Python.
crm_claim/models/__init__.py
Outdated
| crm_claim_category, | ||
| crm_claim_stage, | ||
| res_partner, | ||
| ) |
crm_claim/report/__init__.py
Outdated
| from . import crm_claim_report | ||
| from . import ( | ||
| crm_claim_report, | ||
| ) |
crm_claim/tests/__init__.py
Outdated
| from . import test_crm_claim | ||
| from . import ( | ||
| test_crm_claim, | ||
| ) |
There was a problem hiding this comment.
Please as said by others, we should try to keep changes to minimal.
If anything violates a linter rule, then change it, but otherwise it's better to leave it as it was, so we can review directly the important change (BTW, I can't distinguish if your pull request is actually adding something between all the cosmetic changes).
Besides, if you add a description to the PR, it also becomes easier to know what are we reviewers supposed to review.
Thanks!
crm_claim/__init__.py
Outdated
| from . import ( | ||
| models, | ||
| report, | ||
| ) |
There was a problem hiding this comment.
Although I agree on not changing this to reduce diff, not sure what scripts do you have but those are wrong indeed, this is perfectly valid Python.
|
I have revert back my changes. Would you please review following points:
|
Would you please review following points:
remove _rec_name = 'name' from crm.claim.stage object.
Visible Teams in stage form view which will help to setup default team.
Add OCA logo.