Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Add new themes to TextArea component #9873

Merged
merged 1 commit into from
Mar 21, 2024
Merged

[UI] Add new themes to TextArea component #9873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 59 additions & 0 deletions src/Bootstrap/dist/css/bootstrap.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

57 changes: 57 additions & 0 deletions src/Bootstrap/less/forms.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,63 @@ output {
}
}

textarea.textarea-brand {
color: var(--neutralForeground1Rest);
background-color: var(--neutralBackground1Rest);
border-radius: 4px;
border: 1px solid var(--neutralStroke1Rest);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does same feedback applies here? #9852 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I talked with Joel about CSS variables support, we agreed that this is the best way to do this change, otherwise it will involve adding a lot of extra code, I added more context to that comment but we will continue using CSS variables for now since only IE doesn't support them, and really old versions of other browsers, and created an issue to track it #9875

border-bottom: 2px solid var(--neutralStrokeAccessibleRest);

outline: none !important;
box-shadow: none !important;

&:hover {
border: 1px solid var(--neutralStroke1Hover);
border-bottom: 2px solid var(--neutralStrokeAccessibleHover);
}

&:focus,
&:focus-within,
&:focus-visible {
border: 1px solid var(--neutralStroke1Rest);
border-bottom: 2px solid var(--brandStrokeCompoundRest);
}

&[disabled] {
background-color: transparent;
color: var(--neutralForegroundDisabledRest);
border-color: var(--neutralStrokeDisabledRest);

// Firefox
&::-moz-placeholder {
color: var(--neutralForegroundDisabledRest);
opacity: 1; // Override Firefox's unusual default opacity; see https://github.com/twbs/bootstrap/pull/11526
}
&:-ms-input-placeholder { color: var(--neutralForegroundDisabledRest); } // Internet Explorer 10+
&::-webkit-input-placeholder { color: var(--neutralForegroundDisabledRest); } // Safari and Chrome
}

&[readonly] {
background-color: transparent;
border-color: var(--neutralStrokeDisabledRest);

// Firefox
&::-moz-placeholder {
color: var(--neutralForeground1Rest);
opacity: 1; // Override Firefox's unusual default opacity; see https://github.com/twbs/bootstrap/pull/11526
}
&:-ms-input-placeholder { color: var(--neutralForeground1Rest); } // Internet Explorer 10+
&::-webkit-input-placeholder { color: var(--neutralForeground1Rest); } // Safari and Chrome
}

// Firefox
&::-moz-placeholder {
color: var(--neutralForeground4Rest);
opacity: 1; // Override Firefox's unusual default opacity; see https://github.com/twbs/bootstrap/pull/11526
}
&:-ms-input-placeholder { color: var(--neutralForeground4Rest); } // Internet Explorer 10+
&::-webkit-input-placeholder { color: var(--neutralForeground4Rest); } // Safari and Chrome
}

// Special styles for iOS temporal inputs
//
Expand Down