[UI] Add new themes to TextArea component #9873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add main tracking issue into PR. |
erdembayar
reviewed
Mar 21, 2024
| color: var(--neutralForeground1Rest); | ||
| background-color: var(--neutralBackground1Rest); | ||
| border-radius: 4px; | ||
| border: 1px solid var(--neutralStroke1Rest); |
There was a problem hiding this comment.
Does same feedback applies here? #9852 (comment)
There was a problem hiding this comment.
I talked with Joel about CSS variables support, we agreed that this is the best way to do this change, otherwise it will involve adding a lot of extra code, I added more context to that comment but we will continue using CSS variables for now since only IE doesn't support them, and really old versions of other browsers, and created an issue to track it #9875
erdembayar
approved these changes
Mar 21, 2024
martinrrm
added a commit
that referenced
this pull request
Apr 30, 2024
martinrrm
added a commit
that referenced
this pull request
May 7, 2024
martinrrm
added a commit
that referenced
this pull request
May 16, 2024
martinrrm
added a commit
that referenced
this pull request
May 22, 2024
martinrrm
added a commit
that referenced
this pull request
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Spec: https://github.com/NuGet/Engineering/pull/5209
Addresses #9872
Main Issue: #8773
Adds theme for the TextArea component,