Merge ServerCommon repository into NuGetGallery #10109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the table that will track what packages have been revalidated/repository signed.
Generates the following migration:
```
CREATE TABLE [dbo].[PackageRevalidations] (
[Key] [bigint] NOT NULL IDENTITY,
[PackageId] [nvarchar](128) NOT NULL,
[PackageNormalizedVersion] [nvarchar](64) NOT NULL,
[Enqueued] [datetime2](7),
[ValidationTrackingId] [uniqueidentifier],
[Completed] [bit] NOT NULL,
[RowVersion] rowversion NOT NULL,
CONSTRAINT [PK_dbo.PackageRevalidations] PRIMARY KEY ([Key])
)
CREATE INDEX [IX_PackageRevalidations_PackageId_PackageNormalizedVersion]
ON [dbo].[PackageRevalidations]([PackageId], [PackageNormalizedVersion])
CREATE INDEX [IX_PackageRevalidations_Enqueued]
ON [dbo].[PackageRevalidations]([Enqueued])
CREATE UNIQUE INDEX [IX_PackageRevalidations_ValidationTrackingId]
ON [dbo].[PackageRevalidations]([ValidationTrackingId])
```
For more information, see this [technical spec](https://microsoft.sharepoint.com/teams/NuGet/_layouts/OneNote.aspx?id=%2Fteams%2FNuGet%2FTeam%2FNugetServer%2FNugetServerTeamNote&wd=target%28Specs.one%7C910181C5-8695-4A1C-9792-A56DBB86F1C3%2FPersistence%7C92D53BF1-7B51-4E3B-A77D-1FA4F591D967%2F%29onenote:https://microsoft.sharepoint.com/teams/NuGet/Team/NugetServer/NugetServerTeamNote/Specs.one#Persistence§ion-id={910181C5-8695-4A1C-9792-A56DBB86F1C3}&page-id={92D53BF1-7B51-4E3B-A77D-1FA4F591D967}&end).
Fixes https://github.com/NuGet/Engineering/issues/1436
Add PackageNormalizedVersion property to the PackageMessageData
Moved logging scope to contain "try .. catch" so exceptions logged have CallGuid in their scope.
* Added service bus message delivery related lag tracking. * comments on usage * Test to ensure new metrics are sent. * PR comments addressed. * Argument documentation
Add the ValidatingType to the PackageValidationSet, ValidationStatus and ValidationMessage
…Processor (#171) * Adding the ability to specify MaxConcurrentCalls for the SubscriptionProcessor. * Common logging
* Add symbol error codes
Few changes were missed when adding the symbol error codes.
This will used by monitoring for metrics like: "how many author signatures are valid?"
Add the VSTSSymbolServerRequest entity.
…entity on the SymbolsKey column (#180)
* remove DatabaseGenerated(DatabaseGeneratedOption.Computed) on SybolServerRequest.Created * Add the Migration for dropping the database create option on SymbolServerRequest.Create column
* Initial attempt. * Variable fix. * Unofficial * Not publishing unsigned artifacts.
* update azure identity version & identity client ----
* Start update to new SDK * Move most of the storage to new SDK. * migrate transfer management in AzureStorage * Update Queue Implmentation to v12 SDK * Migrate to v12 SDK * Migrate Tables to new SDK * Switch to generic Blob isntead of BlockBlob * Temporarily disable emu tests and add new interface ones. * Adding Save tests. * Point Transfermanager to temp directory. * Potential fix for incorrect container Uri. * Added some explciit typing. * Add lease adapters to storage SDK types * Update List to use metadata bool. Clean up some comments * Update language version. Add async list * Update StorageExtension to new c# syntax. * Remove unneeded underlying TableEntity. * remove some unclear var usage. * Start update to new SDK * Move most of the storage to new SDK. * migrate transfer management in AzureStorage * Update Queue Implmentation to v12 SDK * Migrate to v12 SDK * Migrate Tables to new SDK * Switch to generic Blob isntead of BlockBlob * Temporarily disable emu tests and add new interface ones. * Adding Save tests. * Point Transfermanager to temp directory. * Potential fix for incorrect container Uri. * Added some explciit typing. * Add lease adapters to storage SDK types * Update List to use metadata bool. Clean up some comments * Update language version. Add async list * Update StorageExtension to new c# syntax. * Remove unneeded underlying TableEntity. * remove some unclear var usage. * BlobClient -> blockBlobClient for perf. * Cleaning up some duplicated messages. Fix setting headers AFTER upload. * Trivially implement ListAsync for other Storages. * Update tests for new changes. * Clean up old tests. --------- Co-authored-by: Drew Gillies <[email protected]>
This is part of an effort to standardize build files across all NuGet Server OSS repos. This can help with a future repository merge effort. * Clean up build files * Fix AssemblyInfo generation * Align solution deps * Move to Package Source Mapping * Move to Central Package Management * Move packages.config to root for better visibility * Add NeutralLanguage from NuGet.Jobs * Add SdkProjects.props to be consistent with other repos * Move to latest SDK as min * Move to latest on packages that vary between repos * Move to latest xunit and fix warnings and errors (messy tests) * Remove version from MicroBuild path * Fix async void in xunit * Delete .editorconfig now that we are clean
…steps (#439) * Move to newer publish test results * Fail on test failure * Pack all projects * Qualify common in more places
* Assign PK and RK on ChildEntity * Remove unnecessary TableEntity field
Add helper method to work around Azure/azure-sdk-for-net#44373 Add missing ListAsync to interface
* Fetch and copy HTTP headers if they are being updated in the copy method * Don't do this in OnSaveAsync, this breaks since the Content-MD5 is set
# Conflicts: # .gitignore # .pipelines/Release-trigger.yml # CONTRIBUTING.md # CredScanSuppressions.json # Directory.Build.props # Directory.Packages.props # NuGet.config # README.md # SdkProjects.props # build.ps1 # test.ps1
Add -SkipArtifacts for further parallelism
This is for consistent with other projects
agr
approved these changes
Aug 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Much like #10091, but for ServerCommon.
This brings ServerCommon git tree into NuGetGallery. This is another step in merging our OSS repositories to ease development.
Since the diff is so large, I don't expect you to review it all. Instead, I'll describe my process:
maininto NuGetGallerydev, allowing unrelated histories.Description of each additional commit:
Commit 71c6f67
Purpose: merge the two Git histories into one, handling merge conflicts of overlapping files
.gitignoreto no longer ignore the build tools (they are in the same repo now, rather than fetched bybuild.ps1.pipelines/Release-trigger.ymlto trigger the ServerCommon release alsobuild.ps1, add assembly version and package version parameterstest.ps1Directory.Packages.props(simple union)NuGet.config(simple union)CredScanSuppressions.json(simple union)README.mdtoREADME.common.md, for a subsequent README fixCommit a1bdaf5
Purpose: merge contents of
README.common.mdintoREADME.mdREADME.mdwith a new shared libraries sectionREADME.common.mdCommit 7feec13
Purpose: clean up builds scripts to allow common tests to be skip, little clean up
-SkipArtifactsand-SkipCommontobuild.ps1-SkipCommontotest.ps1NuGetGallery-CI.yamlto use the new switches, with a new stage for building artifactsCommit e1e4b64
Purpose: change package reference to project reference for projects that now exist in the same repo
All of the projects in ServerCommon
srcare used byNuGetGallery.slnandNuGet.Jobs.sln. These are most of theNuGet.Services.*projects in our codebase (although not all like NuGet.Services.Entities which is already in NuGetGallery repo).In some cases I needed to add a
System.Webreference because this was coming from a transitive package reference previously.Commit 04a00d5
Purpose: make friend assembly (
InternalsVisibleTo) declarations inAssemblyInfo.csnot in MSBuild. The MSBuild method was only done in NuGetGallery.Services. I switched it so we are consistent.Commit e4f95ca
Purpose: clean up init.ps1 to just be better
if ($env:TF_BUILD)condition), better log viewing in AzDO7zabuild tool, not other random things in thetoolsdirectoryRepositories will need to switch away from ServerCommon's
init.ps1in their own build scripts.Commit 082cd37
Change
NuGetGalleryBranchparameter toBranchfor the NuGetGallery packages release build. This is just for consistency. I will fix the related pipeline in a separate PR.