Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minors and combinations #123

Merged
merged 4 commits into from
Jul 18, 2018
Merged

minors and combinations #123

merged 4 commits into from
Jul 18, 2018

Conversation

heiderich
Copy link
Contributor

No description provided.

@heiderich heiderich mentioned this pull request Jul 18, 2018
Closed
thofma
thofma reviewed Jul 18, 2018
View reviewed changes
src/generic/Matrix.jl Outdated
#
###############################################################################

doc""" combinations(n::Int,k::Int)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a new line missing. Also below.

thofma
thofma reviewed Jul 18, 2018
View reviewed changes
Copy link
Member

@thofma thofma left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Could you add a small little test? Just to make sure we don't break by accident.

@thofma
Copy link
Member

thofma commented Jul 18, 2018

Thanks.

@thofma thofma merged commit 68c9f14 into Nemocas:master Jul 18, 2018
@thofma thofma mentioned this pull request Mar 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thofma thofma thofma left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heiderich @thofma