Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify state of combinations #4726

Open
fingolfin opened this issue Mar 10, 2025 · 2 comments
Open

Clarify state of combinations #4726

fingolfin opened this issue Mar 10, 2025 · 2 comments

Comments

@fingolfin
Copy link
Member

Today there was some confusion about combinations because clearly Oscar code uses it but Oscar.combinations does not exist.

Turns out AbstractAlgebra.combinations exists but is not exported.

Moreover we have Oscar.LieAlgebras.combinations which wraps the AA methods but calls sort on the result.

It would be nice to have this function (and perhaps also Oscar.LieAlgebras.multicombinations) as part of our Oscar combinatorics "package".

But I am guessing there is a reason why this is not just exported right now... perhaps someone (@thofma ? @lgoettgens ?) knows and can fill us in what has to be done.

(Once we know what is needed, perhaps @mjrodgers can take care of this)

@thofma
Copy link
Collaborator

thofma commented Mar 11, 2025

The original version was added here Nemocas/AbstractAlgebra.jl#123 as a means to get the minors of a matrix.

The reason we do not export is that people have strong opinions about what the "right" order is, see the sort things in the LieAlgebras code base.

There is also Oscar.OrderedMultiIndexSet, which is yet another implementation of combinations, with some emphasis of iterating in the "right" order.

@fingolfin
Copy link
Member Author

So how do we resolve this? Have an alg or ordering or so argument which allows to select an ordering, with some default the PIs select by vote/dice/whatever?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants