Code

Update 1- and 2-speed AC/HP models#1936

Code

Draft

shorowit wants to merge 38 commits intoresnet_heat_pumpNREL/OpenStudio-HPXML:resnet_heat_pumpfrom one_and_two_speed_hvacNREL/OpenStudio-HPXML:one_and_two_speed_hvacCopy head branch name to clipboard

+6,679-3,809

Commits

Commits on Feb 21, 2025

• Initial progress.

  shorowit

  committed
  458e847

  Copy full SHA for 458e847

• Merge branch 'pan_heaters' of https://github.com/NREL/OpenStudio-HPXML into one_and_two_speed_hvac

  shorowit

  committed
  5c0bd72

  Copy full SHA for 5c0bd72

Commits on Feb 22, 2025

• Merge branch 'pan_heaters' of https://github.com/NREL/OpenStudio-HPXML into one_and_two_speed_hvac

  Show description for 974ccbd
  shorowit

  committed
  974ccbd

  Copy full SHA for 974ccbd

• Merge branch 'pan_heaters' of https://github.com/NREL/OpenStudio-HPXML into one_and_two_speed_hvac

  shorowit

  committed
  c596e2f

  Copy full SHA for c596e2f

• Add/update tests.

  shorowit

  committed
  6b88c50

  Copy full SHA for 6b88c50

• Revert order of measure args.

  shorowit

  committed
  6418aee

  Copy full SHA for 6418aee

• Move datapoint error-checking to schematron. More logic for 1- and 2-speed systems.

  shorowit

  committed
  9543b16

  Copy full SHA for 9543b16

Commits on Feb 24, 2025

• Fix a couple tests.

  shorowit

  committed
  13ab9a6

  Copy full SHA for 13ab9a6

• Latest results.

  

  GitHub Action

  committed
  5c7420f

  Copy full SHA for 5c7420f

• Fix tests. Move a couple methods to model.rb.

  shorowit

  committed
  eb1ba61

  Copy full SHA for eb1ba61

• Latest results.

  

  GitHub Action

  committed
  d63f1b6

  Copy full SHA for d63f1b6

Commits on Feb 25, 2025

• Bugfixes, cleanup.

  shorowit

  committed
  fa54726

  Copy full SHA for fa54726

• Bugfix.

  shorowit

  committed
  33223fb

  Copy full SHA for 33223fb

• Bugfix.

  shorowit

  committed
  581cc7a

  Copy full SHA for 581cc7a

• Relax schematron checks.

  shorowit

  committed
  5f82c27

  Copy full SHA for 5f82c27

• Latest results.

  

  GitHub Action

  committed
  ec7e640

  Copy full SHA for ec7e640

• Require CompressorType for central and mini-split air conditioners and heat pumps.

  shorowit

  committed
  2a9c2b8

  Copy full SHA for 2a9c2b8

Commits on Feb 26, 2025

• Bugfixes.

  shorowit

  committed
  11ee9c8

  Copy full SHA for 11ee9c8

• Latest results.

  

  GitHub Action

  committed
  86370e6

  Copy full SHA for 86370e6

• Merge pull request #1937 from NREL/compressor_type

  Show description for c13975e
  shorowit

  authored
  c13975e

  Copy full SHA for c13975e

• Add sample files.

  shorowit

  committed
  f4ce9f0

  Copy full SHA for f4ce9f0

• Latest results.

  

  GitHub Action

  committed
  007a422

  Copy full SHA for 007a422

• Remove old error-checking code. It's now more complicated and not worth updating, let's just rely on downstream validation.

  shorowit

  committed
  74410f9

  Copy full SHA for 74410f9

• Merge branch 'one_and_two_speed_hvac' of https://github.com/NREL/OpenStudio-HPXML into one_and_two_speed_hvac

  shorowit

  committed
  dfec28a

  Copy full SHA for dfec28a

• Fix EER vs SEER check; EER2 vs SEER2 check is good.

  shorowit

  committed
  fb6467e

  Copy full SHA for fb6467e

• Latest results.

  

  GitHub Action

  committed
  76af612

  Copy full SHA for 76af612

• Latest results.

  

  GitHub Action

  committed
  5e4f0f6

  Copy full SHA for 5e4f0f6

• Expand tests to cover more outdoor temperatures.

  shorowit

  committed
  ba82c84

  Copy full SHA for ba82c84

Commits on Feb 27, 2025

• A little code refactoring.

  shorowit

  committed
  3c9734d

  Copy full SHA for 3c9734d

• Latest results.

  

  GitHub Action

  committed
  99e1de8

  Copy full SHA for 99e1de8

Commits on Mar 1, 2025

• Merge branch 'resnet_heat_pump' of https://github.com/NREL/OpenStudio-HPXML into one_and_two_speed_hvac

  Show description for 9944a55
  shorowit

  committed
  9944a55

  Copy full SHA for 9944a55

• Latest results.

  

  GitHub Action

  committed
  659c434

  Copy full SHA for 659c434

Commits on Mar 5, 2025

• Update capacity/EIR=f(fflow) curves. Simplify/cleanup code a bit. Update to the latest RESNET values and update tests.

  shorowit

  committed
  b33c9d7

  Copy full SHA for b33c9d7

Commits on Mar 6, 2025

• Bugfix. Update/simplify tests.

  shorowit

  committed
  0fb796e

  Copy full SHA for 0fb796e

• Merge branch 'resnet_heat_pump' of https://github.com/NREL/OpenStudio-HPXML into one_and_two_speed_hvac

  Show description for a57d413
  shorowit

  committed
  a57d413

  Copy full SHA for a57d413

• Latest results.

  

  GitHub Action

  committed
  65d036f

  Copy full SHA for 65d036f

• Deep clean to reorganize the code and untangle spaghetti. This kept growing in size as I found more opportunities to improve/simplify the code. The main changes are: 1) moving more code to defaults…

  Show description for 3addc29
  shorowit

  committed
  3addc29

  Copy full SHA for 3addc29

Commits on Mar 7, 2025

• Latest results.

  

  GitHub Action

  committed
  5c4bf30

  Copy full SHA for 5c4bf30