Update 1- and 2-speed AC/HP models #1936
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into one_and_two_speed_hvac
…into one_and_two_speed_hvac # Conflicts: # HPXMLtoOpenStudio/measure.xml # HPXMLtoOpenStudio/resources/hvac.rb
…into one_and_two_speed_hvac
7 tasks
Require `CompressorType` for central & mini-split ACs/HPs
…th updating, let's just rely on downstream validation.
…Studio-HPXML into one_and_two_speed_hvac
21 tasks
…-HPXML into one_and_two_speed_hvac # Conflicts: # HPXMLtoOpenStudio/measure.xml # workflow/tests/base_results/results_simulations_bills.csv # workflow/tests/base_results/results_simulations_energy.csv # workflow/tests/base_results/results_simulations_loads.csv # workflow/tests/base_results/results_simulations_misc.csv
…ate to the latest RESNET values and update tests.
…-HPXML into one_and_two_speed_hvac # Conflicts: # BuildResidentialHPXML/measure.xml # HPXMLtoOpenStudio/measure.xml # workflow/tests/base_results/results_simulations_bills.csv # workflow/tests/base_results/results_simulations_energy.csv # workflow/tests/base_results/results_simulations_hvac.csv # workflow/tests/base_results/results_simulations_loads.csv # workflow/tests/base_results/results_simulations_misc.csv
…rowing in size as I found more opportunities to improve/simplify the code. The main changes are: 1) moving more code to defaults.rb, 2) putting RESNET MINHERS assumptions all in one place rather than scattered throughout, 3) calculating/storing default assumptions up front so we don't need to call out to HVAC methods from all over the place, 4) Replacing speed-based arrays with single values where values no longer differ by speed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Branches off of #1932.
Updates 1-speed and 2-speed AC/HP models per RESNET MINHERS Addendum 82.
Also allows detailed performance datapoints to be specified for these systems.
Adds a lot more tests.
Checklist
Not all may apply:
EPvalidator.xml) has been updatedopenstudio tasks.rb update_hpxmls)HPXMLtoOpenStudio/tests/test*.rband/orworkflow/tests/test*.rb)openstudio tasks.rb update_measureshas been run